restart and stop fail

[warthog]

when running 'sabnzbdplus restart' or 'sabnzbdplus stop' it fails with the following message

mktemp: invalid option -- -


Version: 0.6.0RC1 <-----  Yeah, I know. Wrong place for this post. Mods, please move.  TY
OS: Ubuntu HH
Install-type: repo
Firewall Software: None
Are you using IPV6? no
Is the issue reproducible? yes

[jcfp]

mktemp: invalid option -- -

OS: Ubuntu HH

I'm assuming you mean ubuntu hardy (8.04). Please post the output of 'mktemp --help' on that os.

[warthog]

Yes, by HH I mean 8.04 Hardy Heron

Output of mktemp --help is:

mktemp: invalid option -- -
Usage: mktemp [-V] | [-dqtu] [-p prefix] [template]

After seeing this I took a look at the stop portion of the sabnzbdplus script, and all appears to be normal there. So, I figured something must have changed with a recent system update. I'm not clear on the details but it seems that --tmpdir(from my sabnzbdplus script) is not a valid option now for mktemp. After some digging I editted the script as seen below.

Old:

Code: Select all

TMPFILE="$(mktemp --tmpdir sabnzbdplus.XXXXXXXXXX)"

New:

Code: Select all

TMPFILE="$(mktemp -t sabnzbdplus.XXXXXXXXXX)"

Now all is well.

[jcfp]

Suspected that would be the issue. Fixed script uploaded to the ppa, for hardy anyway. In current mktemp, -t is deprecated, and --tmpdir does exist, although I don't know when exactly it was introduced.

Anyway, thanks for reporting.

[warthog]

Thanks for helping me get started in the right direction and for explaining the situation further.

[marcuso]

Could it be this Bug was re-introduced ? I have the same issue again with hardy with latest build from the repository.
I was able to fix it by completely removing the "--tmpdir" option from the init-script - actually i don´t see the sense anyway. "-t" also makes no real sense to me as well.
Seems to me that mktemp would generate the temp-file in /tmp with any of those options

So even if this is fixed for me it might be good to have it fixed in repository so others do not run into the same issue.

BR
Marcus

[jcfp]

Could it be this Bug was re-introduced ? I have the same issue again with hardy with latest build from the repository.

Looks like it, to be fixed soon. Thanks for reporting.