Test-email tests saved values, not currently entered values.

Report & discuss bugs found in SABnzbd
Forum rules
Help us help you:
  • Are you using the latest stable version of SABnzbd? Downloads page.
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
Post Reply
trezor
Newbie
Newbie
Posts: 3
Joined: April 16th, 2014, 2:38 am

Test-email tests saved values, not currently entered values.

Post by trezor »

Technically speaking, this is really a minor bug, but if you don't know about this/is able to guess it, email configuration can be a real confusing thing.

To reproduce the issue do the following:
  • Setup email notification against gmail or whatever in sabnzbd.
  • Have a heartbleed bug, change your email account's password.
  • Go to sabnzbd's notification configuration.
  • Enter your new password under "Email account settings". DO NOT click save.
  • Click "Test".
Observe that: Sending test-email will fail until you click "Save".

It's not obvious that you need to save before the config can be tested. Personally I expect "Test" allows me to verify that something works before saving.

Any chance getting this fixed? :)
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Test-email tests saved values, not currently entered val

Post by shypike »

Maybe, it goes into the todo list.
trezor
Newbie
Newbie
Posts: 3
Joined: April 16th, 2014, 2:38 am

Re: Test-email tests saved values, not currently entered val

Post by trezor »

Thanks. Sounds good.

Not any deal killer by any means, but just thought I'd bring it up since I think that would improve an otherwise excellent product :)

Seeing as I now found the github issue list, any point resubmitting there?

https://github.com/sabnzbd/sabnzbd/issues

And if I decide I have time to look into this myself, are there any strict requirements for pull-requests to be accepted? Any contributer guidelines I should be aware of or look into?
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Test-email tests saved values, not currently entered val

Post by shypike »

trezor wrote: And if I decide I have time to look into this myself, are there any strict requirements for pull-requests to be accepted? Any contributer guidelines I should be aware of or look into?
It would be great if you did this.
Please base your work on the 0.7.x branch.
trezor
Newbie
Newbie
Posts: 3
Joined: April 16th, 2014, 2:38 am

Re: Test-email tests saved values, not currently entered val

Post by trezor »

Done and done :)
Post Reply