Problem with NZBClub RSS Feed Downloads

Report & discuss bugs found in SABnzbd
Forum rules
Help us help you:
  • Are you using the latest stable version of SABnzbd? Downloads page.
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
Post Reply
ScrawnyB
Newbie
Newbie
Posts: 2
Joined: July 9th, 2014, 9:34 pm

Problem with NZBClub RSS Feed Downloads

Post by ScrawnyB »

Hello there.

I'm currently experiencing some problems with how SABNZBd is URL encoding the download links from NZBClub's RSS feeds...


For the sake of demonstrating, I am going to use this example:

RSS Feed URL: XXX
In case the link doesn't work... the RSS looks like this...

Code: Select all

<?xml version="1.0" encoding="utf-8"?>
<rss xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" version="2.0">
  <channel>
    <description>Latest Search Result for "universe works s03e01 720p x264"</description>
    <generator>Feed Generator</generator>
    <item>
      <description>Size: 1.28 GB in 29 files.<br />Poster: Speedy &lt;[email protected]&gt; <br />Newsgroup: alt.binaries.boneless <br />Files Information:  [27 Archive Files 1,767 p] |  [1 Par2 Files 1 p] |  [1 NFO Files]
</description>
      <enclosure length="1371808763" type="text/xml" url="http://www.nzbclub.com/nzb_get/37773947/scnzb efnet 520624 How the Universe Works S03E01 Sun 720p HDTV x264 DHD how the universe works s03e01 720p dhd.nzb" />
      <guid isPermaLink="true">http://www.nzbclub.com/nzb_view37773947</guid>
      <link>http://www.nzbclub.com/nzb_view/37773947/scnzb_efnet_520624_How_the_Universe_Works_S03E01_Sun_720p_HDTV_x264_DHD_how_the_universe_works_s03e01_720p_dhd</link>
      <pubDate>Wed, 09 Jul 2014 21:15:43 -0500</pubDate>
      <title>[#scnzb@efnet][520624] How.the.Universe.Works.S03E01.Sun.720p.HDTV.x264-DHD "how.the.universe.works.s03e01.720p-dhd" </title>
    </item>
    <link>http://www.nzbclub.com/nzbfeeds.aspx</link>
    <title>NZBClub RSS</title>
    <pubDate>Wed, 09 Jul 2014 21:39:44 -0500</pubDate>
    <language>en</language>
  </channel>
</rss>

I can manually download the NZB from my browser, but SAB fails with this message:

Code: Select all

2014-07-09 22:21:43,825	WARNING:	Empty NZB file scnzb%2520efnet%2520520624%2520How%2520the%2520Universe%2520Work [http://www.nzbclub.com/nzb_get/37773947/scnzb%2520efnet%2520520624%2520How%2520the%2520Universe%2520Works%2520S03E01%2520Sun%2520720p%2520HDTV%2520x264%2520DHD%2520how%2520the%2520universe%2520works%2520s03e01%2520720p%2520dhd.nzb]
The real URL should be:

Code: Select all

http://www.nzbclub.com/nzb_get/37773947/scnzb%20efnet%20520624%20How%20the%20Universe%20Works%20S03E01%20Sun%20720p%20HDTV%20x264%20DHD%20how%20the%20universe%20works%20s03e01%20720p%20dhd.nzb

The difference is the %20 URL encoding for spaces is being changed to %2520 in SAB before trying to download...
So, basically it looks like SABnzbd is trying to double-encode the URL... Any thoughts on how this could be fixed?
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Problem with NZBClub RSS Feed Downloads

Post by shypike »

I have removed the RSS URL, because I think it contains personal info.
I'll have a look at this.
ScrawnyB
Newbie
Newbie
Posts: 2
Joined: July 9th, 2014, 9:34 pm

Re: Problem with NZBClub RSS Feed Downloads

Post by ScrawnyB »

Thanks. No personal info in that original link though, as far as I know, just some extra search preferences.

Found this section of code though in rss.py that looks suspicious and probably responsible:

Code: Select all

      if link:
                # Make sure spaces are quoted in the URL
                if 'nzbclub.com' in link:
                    link, path = os.path.split(link.strip())
                    link = '%s/%s' % (link, urllib.quote(path))
                else:
                    link = link.strip().replace(' ','%20')

                newlinks.append(link)


Thoughts?
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Problem with NZBClub RSS Feed Downloads

Post by shypike »

Interesting, I forgot about this piece of code.
It looks like at some time nzbclub needed some special treatment.
I'll look into it, but it may take some time.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Problem with NZBClub RSS Feed Downloads

Post by shypike »

Sorry for the late reply.
For me it works fine with and without the extra code, weird.

Even so, the extra code doesn't seem to be necessary any longer and maybe harmful in some situations.
I'll remove it in the next release.
Post Reply