SFV validation after invalid PAR2 files

Want something added? Ask for it here.
Post Reply
antartic
Newbie
Newbie
Posts: 3
Joined: September 4th, 2014, 6:09 am

SFV validation after invalid PAR2 files

Post by antartic »

Lately I get a few cases where the par2 files are bad, but there is a SFV file.

Would it be possible to get a fallback option where sabnzbd tries to validate the files using sfv after the par2 files are deemed invalid?
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: SFV validation after invalid PAR2 files

Post by shypike »

This is already done.
However, the chance that when the par2 verification fails while the SFV verification succeeds, is very very small.
The SFV verification was implemented to support posts without par2 files (these exist).
It was very easy to implement it aslo as a fall-back for failing par2 verifications, but its usefulness is doubtful.
antartic
Newbie
Newbie
Posts: 3
Joined: September 4th, 2014, 6:09 am

Re: SFV validation after invalid PAR2 files

Post by antartic »

It is done? Did I read over this feature or did you mean it's coded and will be in the next version?

But yeah I understand there will be very few cases this will work, but still it will help me avoid manual handling in those cases.

Thank you! :D
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: SFV validation after invalid PAR2 files

Post by shypike »

If you enable SFV checks in Config->Switches, it will use method as a backup.
antartic
Newbie
Newbie
Posts: 3
Joined: September 4th, 2014, 6:09 am

Re: SFV validation after invalid PAR2 files

Post by antartic »

Hm, I got SFV checks enabled. That works wonders if there are no PAR2 files at all.

But if I get empty/broken PAR2 files it just says: "Invalid par2 files, cannot verify or repair" and stops, no fallback method that I can see activated.

In this case the culprit was sanford.and.son.313.720p-dimension grabbed from nzb.su which did have a good SFV file but empty PAR2 files.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: SFV validation after invalid PAR2 files

Post by shypike »

Invalid par2 files might be an issue.
"Not enough block to repair" will trigger the SFV check.
I'll check.
zoggy
Release Testers
Release Testers
Posts: 75
Joined: February 8th, 2011, 3:08 pm

Re: SFV validation after invalid PAR2 files

Post by zoggy »

http://forums.sabnzbd.org/viewtopic.php ... 610#p96610

basically #scnzb releases are being posted with 'invalid pars' when sab tries to d/l them.. it fails regardless if the pars is needed or not. using another downloader you see that they extract.. because the fact that it has invalid pars is only a warning not a roadblock. yes if the release needs those pars.. then it of course would fail to extract as well.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: SFV validation after invalid PAR2 files

Post by shypike »

You can always choose to disable the option "Process only verified jobs" in Config->Switches.
There are some side-effects of course.
SFV verification has been improved a bit in 0.7.19RC3.
Post Reply