Fetching command option

Want something added? Ask for it here.
Post Reply
pobox
Full Member
Full Member
Posts: 104
Joined: May 3rd, 2008, 6:11 pm

Fetching command option

Post by pobox »

I would like to use the NNTP command:

ARTICLE <msg-id>

instead of:

BODY <msg-id>

If there is already a way to switch from one command to the other I'm sorry I missed it while searching.
User avatar
sander
Release Testers
Release Testers
Posts: 8847
Joined: January 22nd, 2008, 2:22 pm

Re: Fetching command option

Post by sander »

Why do you want to use ARTICLE and not BODY?

Technically you could change it, probably in file sabnzbd/newswrapper.py "command = 'BODY <%s>\r\n' % (self.article.article)", but I guess SAB will not work anymore after that; more changes are needed to remove the stuff that ARTICLE adds.

So you probably want something else? Can you explain?
pobox
Full Member
Full Member
Posts: 104
Joined: May 3rd, 2008, 6:11 pm

Re: Fetching command option

Post by pobox »

The only reason is to work around a malfunctioning news server. Why should SABnzbd do that? Maybe SABnzbd shouldn't, but it's a server in the sticky "Getting a lot of "not enough repair blocks"?" which a lot of people are using as a backup. Maybe the best solution is to contact the operator and tell them to fix their damn news server.

The server 'free.xsusenet.com' is running the problematic 'NNTPSwitch' software, and the response to BODY <msg-id> is sometimes an empty body:

BODY <4ec4a2d8$0$1710$c3e8da3$[email protected]>
222 0 <4ec4a2d8$0$1710$c3e8da3$[email protected]>
.

So it sometimes sends just code 222 and then a dot on a line by itself. Some newsreaders don't handle that well, if it's treated as a retrieved body, even though empty, it causes problems.

But the command ARTICLE <msg-id> retrieves the complete head and body from the otherwise broken XSusenet NNTPSwitch contraption, so it's a workaround.

SABnzbd does not start decoding a yEnc body until it finds a =ypart
For UUE and Mime, I don't know how it would start decoding after the headers and a blank line are discarded.

I still have that ancient relic BNR2 which can request by either ARTICLE or BODY. Meanwhile, I'll watch the XSusenet server and report here if it does get fixed.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Fetching command option

Post by shypike »

Doesn't this server just need the GROUP command before BODY?
There's an option for that in Config->Switches.
pobox
Full Member
Full Member
Posts: 104
Joined: May 3rd, 2008, 6:11 pm

Re: Fetching command option

Post by pobox »

I thought of that after I posted the above message and I sure wish that GROUP before BODY did work but it doesn't seem to.

GROUP alt.binaries.b4e
211 25000000 252959211 277959211 alt.binaries.b4e
BODY <4ec4a2d8$0$1710$c3e8da3$[email protected]>
222 0 <4ec4a2d8$0$1710$c3e8da3$[email protected]>
.

GROUP alt.binaries.boneless
211 25000000 4622344403 4647344403 alt.binaries.boneless
BODY <4ec4a2d8$0$1710$c3e8da3$[email protected]>
222 0 <4ec4a2d8$0$1710$c3e8da3$[email protected]>
.
User avatar
sander
Release Testers
Release Testers
Posts: 8847
Joined: January 22nd, 2008, 2:22 pm

Re: Fetching command option

Post by sander »

pobox wrote:
But the command ARTICLE <msg-id> retrieves the complete head and body from the otherwise broken XSusenet NNTPSwitch contraption, so it's a workaround.

SABnzbd does not start decoding a yEnc body until it finds a =ypart
For UUE and Mime, I don't know how it would start decoding after the headers and a blank line are discarded.

I still have that ancient relic BNR2 which can request by either ARTICLE or BODY. Meanwhile, I'll watch the XSusenet server and report here if it does get fixed.
Purely as a test, I replaced BODY with ARTICLE in the SAB source code, and tested a download: the download happens, but results in "blabla.rar -> Unknown encoding" for each rar en par2 file. So, FWIW, it is not a matter of just putting the ARTICLE command; if ARTICLE is used, some stripping has to be done.

But let's wait for Shypike's analysis and advice.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Fetching command option

Post by shypike »

sander wrote:
pobox wrote: But let's wait for Shypike's analysis and advice.
Yeah, yeah, might take a while.
Do these guys still give out free accounts?
I don't like the "sometimes" part...
pobox
Full Member
Full Member
Posts: 104
Joined: May 3rd, 2008, 6:11 pm

Re: Fetching command option

Post by pobox »

By "sometimes" I mean that the empty body error is 100% repeatable with certain articles, but it only affects some of the articles of each file.
User avatar
jcfp
Release Testers
Release Testers
Posts: 993
Joined: February 7th, 2008, 12:45 pm

Re: Fetching command option

Post by jcfp »

Maybe they do it intentionally (breaking and/or not fixing their '''free''' service), to get people to sign up with their paid offerings? Did anyone even try telling xsusenet to fix their server? After all, this is a pure server side error.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Fetching command option

Post by shypike »

pobox wrote:By "sometimes" I mean that the empty body error is 100% repeatable with certain articles, but it only affects some of the articles of each file.
That's what I meant. This makes it hard to test :(
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Fetching command option

Post by shypike »

@Sander:
I implemented the fix you emailed and it works.
It's only enabled for free.xsusenet.com (hard-coded).
I'm not going to make a (special) option for it because that either would mean
using it for all servers or having a setting per server.
The latter would increase the amount downloaded and the latter is just overkill.

I'm thinking of adding it to 0.7.0Beta3.

PS.
The "bug" is very weird indeed.
I just picked some NZB and it missed a bunch of random articles (about 5%).
With the "article" fix it downloaded all articles without problems.
I would almost believe jcfp's suggestion.
User avatar
sander
Release Testers
Release Testers
Posts: 8847
Joined: January 22nd, 2008, 2:22 pm

Re: Fetching command option

Post by sander »

jcfp wrote:Maybe they do it intentionally (breaking and/or not fixing their '''free''' service), to get people to sign up with their paid offerings? Did anyone even try telling xsusenet to fix their server? After all, this is a pure server side error.
Hmmm. So if the testdrive doesn't work properly, people will pay/buy the real service?

Has anybody a paid-for xsusenet.com service? If so, he/she could test if the BODY bug exists there.
Post Reply