Repair failed, not enough repair blocks nearly everytime

Get help with all aspects of SABnzbd
Forum rules
Help us help you:
  • Are you using the latest stable version of SABnzbd? Downloads page.
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
User avatar
sander
Release Testers
Release Testers
Posts: 8829
Joined: January 22nd, 2008, 2:22 pm

Re: Repair failed, not enough repair blocks nearly everytime

Post by sander »

@SigHunter:

Did you use my git version, so from https://github.com/sanderjo/sabnzbd.git, which has automagic -N detecition & usage ? Or did you use the official SABnzbd git version?

And: thank you for bringing this up with your "However I can without any problem (always!) repair it with par2repair -N *.par2 *" in your opening post.
SigHunter
Newbie
Newbie
Posts: 5
Joined: January 8th, 2016, 4:45 am

Re: Repair failed, not enough repair blocks nearly everytime

Post by SigHunter »

i successfully ran the commands you posted, thus using the version from the par2optionN-branch
User avatar
safihre
Administrator
Administrator
Posts: 5366
Joined: April 30th, 2015, 7:35 am
Contact:

Re: Repair failed, not enough repair blocks nearly everytime

Post by safihre »

I asked the par2cmdline dev why this -N was introduced:
https://github.com/Parchive/par2cmdline/issues/65

Basically because the way it used to search (or when you turn on -N) can cause in rare cases and infinite detection loop, causing the repair to run for ages, he calls it a sort of DDOS.
Windows/OSX use par2tbb, which is vulnerable for this bug, but we never got any reports about that, so probably safe to assume for usenet posts don't have any problems.
If you like our support, check our special newsserver deal or donate at: https://sabnzbd.org/donate
User avatar
sander
Release Testers
Release Testers
Posts: 8829
Joined: January 22nd, 2008, 2:22 pm

Re: Repair failed, not enough repair blocks nearly everytime

Post by sander »

Iasked the par2cmdline dev why this -N was introduced:
https://github.com/Parchive/par2cmdline/issues/65
Ah, great. Thank you. And great that the maintainer has reacted. I've uploaded an example problematic set.
Basically because the way it used to search (or when you turn on -N) can cause in rare cases and infinite detection loop, causing the repair to run for ages, he calls it a sort of DDOS.
Windows/OSX use par2tbb, which is vulnerable for this bug, but we never got any reports about that, so probably safe to assume for usenet posts don't have any problems.
What is your exact assumption? That "-N" has been implemented already in par2tbb, as an always-on feature?
User avatar
safihre
Administrator
Administrator
Posts: 5366
Joined: April 30th, 2015, 7:35 am
Contact:

Re: Repair failed, not enough repair blocks nearly everytime

Post by safihre »

What is your exact assumption? That "-N" has been implemented already in par2tbb, as an alway-on option?
No, the -N is the 'old' behavior, the way it was implemented before par2cmdline 0.6 and thus also the way it is in par2tbb (since that's just par2cmdline 0.4).
Only when they discovered this 'DDOS/collision-bug' recently they disabled the old block-search behavior to avoid the bug in par2cmdline 0.6+.
If you like our support, check our special newsserver deal or donate at: https://sabnzbd.org/donate
User avatar
sander
Release Testers
Release Testers
Posts: 8829
Joined: January 22nd, 2008, 2:22 pm

Re: Repair failed, not enough repair blocks nearly everytime

Post by sander »

safihre wrote:
What is your exact assumption? That "-N" has been implemented already in par2tbb, as an alway-on option?
No, the -N is the 'old' behavior, the way it was implemented before par2cmdline 0.6 and thus also the way it is in par2tbb (since that's just par2cmdline 0.4).
Only when they discovered this 'DDOS/collision-bug' recently they disabled the old block-search behavior to avoid the bug in par2cmdline 0.6+.
Oh ... wow ... ::)

So introducing it again in SABnzbd could be dangerous?

Let's wait for the author's response on the specific example on github.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Repair failed, not enough repair blocks nearly everytime

Post by shypike »

We have had reports of hanging par2 repairs on Windows.
Advice was always: turn off multithreading in Config->Switches.
The cause may have been the bugs associated with -N
moreje
Newbie
Newbie
Posts: 15
Joined: October 9th, 2010, 7:44 am

Re: Repair failed, not enough repair blocks nearly everytime

Post by moreje »

OK, so...I'm running SAB on Ubuntu 15.10 ...
..often get this "not enough repair block" error...
...same data are easily repaired by quickpar running through Wine...
SO..
How should I configure SAB to make it works?
Thanks for your help
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Repair failed, not enough repair blocks nearly everytime

Post by shypike »

Did you try what was discussed here?
Use Beta6, install a recent par2cmdline and set the -N parameter.
moreje
Newbie
Newbie
Posts: 15
Joined: October 9th, 2010, 7:44 am

Re: Repair failed, not enough repair blocks nearly everytime

Post by moreje »

I'm not English native speaker...so hard to decode everything in this thread...
I uses releases provided with ubuntu, where do I find Beta6?
User avatar
sander
Release Testers
Release Testers
Posts: 8829
Joined: January 22nd, 2008, 2:22 pm

Re: Repair failed, not enough repair blocks nearly everytime

Post by sander »

moreje wrote:I'm not English native speaker...so hard to decode everything in this thread...
I uses releases provided with ubuntu, where do I find Beta6?
In the PPA by jcfp. See instruction on http://wiki.sabnzbd.org/install-ubuntu-repo how to use it.
Post Reply