Make "Checking" a Priority Over Downloading?

Get help with all aspects of SABnzbd
Forum rules
Help us help you:
  • Are you using the latest stable version of SABnzbd? Downloads page.
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
Post Reply
Hossy
Newbie
Newbie
Posts: 7
Joined: May 8th, 2017, 7:50 am

Make "Checking" a Priority Over Downloading?

Post by Hossy »

I'm new to SABnzbd (and I love it btw)... I was wondering about the check before download option. I definitely have it enabled, but I noticed it only checks the currently active queue item. If there a way to have SABnzbd prioritize "checking" over downloading? This would allow me to quickly filter out queue items with missing articles so I can find/choose alternate NZBs to get (as can sonarr). :)
User avatar
jcfp
Release Testers
Release Testers
Posts: 989
Joined: February 7th, 2008, 12:45 pm

Re: Make "Checking" a Priority Over Downloading?

Post by jcfp »

For some people, minimizing bandwidth use is crucial (satellite or similar pay-per-gb connectivity) which is where the pre-check comes in. Unfortunately, running the pre-check long before starting the actual download would defeat its very purpose, as articles could be removed from the server in the meantime. First checking all queued jobs before starting any downloading could very well have that effect, especially since many server are rather slow to respond to the type of inquiry the pre-check uses.

For almost all other cases - unless your internet connection has some kind of medieval traffic volume caps - you're probably be better off with the 'abort jobs that cannot complete' approach that checks job health in real time while downloading. Added advantage is that it can look at the actual downloaded data rather than having to rely on whether a server claims to have a certain article, which may still be damaged or otherwise unusable.
Hossy
Newbie
Newbie
Posts: 7
Joined: May 8th, 2017, 7:50 am

Re: Make "Checking" a Priority Over Downloading?

Post by Hossy »

jcfp wrote:running the pre-check long before starting the actual download would defeat its very purpose, as articles could be removed from the server in the meantime.
I don't agree here. The odds are much less of the article being removed between the time you check and the time you download versus never checking. For young articles, your argument holds more merit, but I feel the benefit gained (i.e. the time saved) checking before downloading is much more valuable. This might simply come down to user preference, which is what I'm requesting here. I have heard people in the IRC channel say they prefer straight download too, so just as check before download is a preference, this could be too (or enabling one enables both).

The other problem this would solve is that "Checking" status queue items are not included in the total count or the timer. The argument was made on this that unchecked items are validated yet and aren't marked as pending download and are therefore not counted in the "to be downloaded" total. Prioritizing (or reserving one or a few connections) the checking for articles would also resolve this.
User avatar
safihre
Administrator
Administrator
Posts: 5366
Joined: April 30th, 2015, 7:35 am
Contact:

Re: Make "Checking" a Priority Over Downloading?

Post by safihre »

The precheck is not a feature we actively promote because its not reliable. We kind of wish we could remove it, but then again many users like it.
There are too many servers out there where a check lasts almost as long as real download would. And we have an unidentified bug that causes the precheck to hang the download, which we have not been able to reliablly reproduce (or fix) for more than a year now.

So to summarize, we don't want to make extra work of this feature..
But if you are a python programmer, we welcome contributions :)
If you like our support, check our special newsserver deal or donate at: https://sabnzbd.org/donate
Hossy
Newbie
Newbie
Posts: 7
Joined: May 8th, 2017, 7:50 am

Re: Make "Checking" a Priority Over Downloading?

Post by Hossy »

safihre wrote:There are too many servers out there where a check lasts almost as long as real download would.
Maybe add a server-level setting that disallows precheck?
safihre wrote:And we have an unidentified bug that causes the precheck to hang the download, which we have not been able to reliablly reproduce (or fix) for more than a year now.

So to summarize, we don't want to make extra work of this feature..
But if you are a python programmer, we welcome contributions :)
I don't spend forever digging into the code like you guys, but I'm willing to take a look and help if possible if you can provide more detail on the bug or point me to web link.
Post Reply