Incompatible feed file (since upgrade to 2.3.6)

[OneCD]

Hello.

After the successful upgrade of SABnzbd from 2.3.5 to 2.3.6 on Debian 9.6, my custom RSS feed file is no longer accepted:

Code: Select all

2018-12-22 05:58:50,160::INFO::[rss:510] Starting scheduled RSS read-out for "my locally filtered feed"
2018-12-22 05:58:50,270::INFO::[rss:338] Incompatible feed file:///share/feed/output.rss
2018-12-22 05:58:50,274::INFO::[rss:339] Traceback: 
Traceback (most recent call last):
  File "/opt/sabnzbd/sabnzbd/rss.py", line 336, in run_feed
    link, infourl, category, size, age, season, episode = _get_link(entry)
  File "/opt/sabnzbd/sabnzbd/rss.py", line 651, in _get_link
    if entry.id and entry.id != link and entry.id.startswith('http'):
  File "/opt/sabnzbd/sabnzbd/utils/feedparser.py", line 416, in __getattr__
    raise AttributeError, "object has no attribute '%s'" % key
AttributeError: object has no attribute 'id'

My locally-built feed file has this basic layout:

Code: Select all

<?xml version="1.0" encoding="utf-8"?>
<rss version="2.0">
   <channel>
      <title>my RSS Feed</title>
      <item>
         <title>video title here</title>
         <link>nzb download link here</link>
         <category>assigned cat</category>
         <matched>filter match reason</matched>
         <size>blah GiB</size>
      </item>
   </channel>
</rss>

The recent changelog mentioned an RSS-related item. Is there something I should modify in my RSS file so SAB will accept it?

Thank you.

[safihre]

Damn, stupid basic python mistake.
Nothing wrong with your feed.

[OneCD]

Ah, no worries. Thank you.

Is there any way I can patch my current version so it can read my feed again?

[OneCD]

I've applied the modified [rss.py] file in the 'develop' branch (as indicated here), and the feed is working again. Thank you.

Any possibility of pushing that fix into the 'master' branch?

side-note: when I view a specific RSS feed details in SAB, Firefox (on my client PC) goes 100% CPU on a single thread for 15-20 seconds. The rest of the SAB UI is unresponsive during this time. Firefox 64.0 on Debian 9.6.

[safihre]

Weird, we use quite boring html and Javascript. No real fancy frameworks etc!