'Save Changes' for server won't save unless settings are valid

Get help with all aspects of SABnzbd
Forum rules
Help us help you:
  • Are you using the latest stable version of SABnzbd? Downloads page.
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
Post Reply
User avatar
OneCD
Hero Member
Hero Member
Posts: 557
Joined: March 4th, 2017, 3:47 pm

'Save Changes' for server won't save unless settings are valid

Post by OneCD »

Hi Guys.

I've just noticed if I attempt to add a personal note to a server that is not yet fully configured, I get a 'failed' message as the "server address xxx:119" is not valid". This is correct - I often include a dummy server address while I'm testing SAB package installation and upgrading.

But, is it really necessary to validate settings before allowing them to be saved?

We have a separate button for 'Test Server', so the user can check the validity of their settings whenever they like. I don't think there's a need to restrict saving all server settings just because the server address isn't valid. The same dummy address was configured during the initial wizard setup and was accepted without error.

Thank you. :)
Stuff I like: Apache bash cron DD-WRT Debian DNSMasq Entware FireFox GitHub ImageMagick Kate KDE LibreELEC Netrunner NFS NVIDIA OpenVPN Orvibo-S20 pfSense Python Raspberry-Pi RAID SABnzbd Transmission Usenet VirtualBox Watcher3 XFCE
User avatar
safihre
Administrator
Administrator
Posts: 5366
Joined: April 30th, 2015, 7:35 am
Contact:

Re: 'Save Changes' for server won't save unless settings are valid

Post by safihre »

We only check a very few fields to be there. If they aren't there, it might break the code in a later stage.
So rather than allowing bad settings, we just reject them.
I am surprised that it worked during wizard, the saving should go through the same code. Although now I am starting to doubt that :P
If you like our support, check our special newsserver deal or donate at: https://sabnzbd.org/donate
User avatar
OneCD
Hero Member
Hero Member
Posts: 557
Joined: March 4th, 2017, 3:47 pm

Re: 'Save Changes' for server won't save unless settings are valid

Post by OneCD »

No worries, thanks @safihre. :)
Stuff I like: Apache bash cron DD-WRT Debian DNSMasq Entware FireFox GitHub ImageMagick Kate KDE LibreELEC Netrunner NFS NVIDIA OpenVPN Orvibo-S20 pfSense Python Raspberry-Pi RAID SABnzbd Transmission Usenet VirtualBox Watcher3 XFCE
Post Reply