Repair Failed - when there is no need to repair anything

Get help with all aspects of SABnzbd
Forum rules
Help us help you:
  • Are you using the latest stable version of SABnzbd? Downloads page.
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
Post Reply
wevotedno
Newbie
Newbie
Posts: 22
Joined: October 18th, 2010, 2:40 am

Repair Failed - when there is no need to repair anything

Post by wevotedno »

Hi all, i keep getting the "Repair Failed, not enough repair blocks" when there is absolutely no need. The completed folder gets tagged as  _FAILED_, the download is not unrared but it is not broken. I verify using quick par standalone and everything checks and then i manually unrar.

My paths are correct, didn't make any chances from a previously working configuration, permissions are ok, nzb name is short enough, so...

I have debug logging but i did not know if it is ok to post here.

Keep in mind that this happens with all my downloads for a couple of days now.

Please advise

thanks

UPDATE

I narrowed it down to this:

When article/filename contains this : it gets broken
Last edited by wevotedno on November 1st, 2010, 4:32 pm, edited 1 time in total.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Repair Failed - when there is no need to repair anything

Post by shypike »

Which OS do you use?
Can you email a failing NZB to bugs at sabnzbd.org ?
BTW: a filename with an ':' isn't possible on Windows (and maybe problematic on other OSes).
wevotedno
Newbie
Newbie
Posts: 22
Joined: October 18th, 2010, 2:40 am

Re: Repair Failed - when there is no need to repair anything

Post by wevotedno »

email sent.
sailmakered
Release Testers
Release Testers
Posts: 9
Joined: September 16th, 2010, 8:50 pm

Re: Repair Failed - when there is no need to repair anything

Post by sailmakered »

I have had a similar problem and traced to the fact that I was not downloading samples.  The post processing seems to fail if the sample fails so I just set it to download then delete at the bottom of switches page.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Repair Failed - when there is no need to repair anything

Post by shypike »

This happens when the par2 files belonging to a sample are not recognizable as samples.
So SABnzbd skips the actual sample, but still downloads an extra set of par2 files
and assumes that set needs verification too.
Root cause: posters ignoring naming conventions.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Repair Failed - when there is no need to repair anything

Post by shypike »

wevotedno wrote: email sent.
The one who uploaded this to Usenet is a complete idiot.
First of all, the file names have colons in them, which won't fly under Windows.
SABnzbd must rename these files.
Second, the uploader has renamed the files after the par2 files were generated.
This means that par2 starts looking for files that simply aren't there.

In the mean time we have received some more messages about this deranged uploader(s).

We may be able to program around this lunacy, but I'm not sure we should do that.
sailmakered
Release Testers
Release Testers
Posts: 9
Joined: September 16th, 2010, 8:50 pm

Re: Repair Failed - when there is no need to repair anything

Post by sailmakered »

Too funny.

We should feel lucky this is not the rule.  Most posters are good at it.

Hey shypike, has anyone written a par/rar interface?  If not could you give me an idea where to look in the code of SAB for those functions?
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Repair Failed - when there is no need to repair anything

Post by shypike »

It's all in newsunpack.py.
I am looking at a solution, which will probably work.
Most of the work goes into testing that it doesn't break other situations.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Repair Failed - when there is no need to repair anything

Post by shypike »

I have to retract some of my previous statements.
The uploads discussed are not as mad as I thought.
They do have badly chosen filenames, containing colons.
(The uploader must have used Linux and have a dislike for Windows users).

The par2 program has a rather peculiar handling of colons in filenames on Windows and OSX.
This doesn't match the way SABnzbd substitutes characters.
On Windows it cahnges 20:30:40.rar to 203A303A40.rar.
The OSX case is particularly bad because OSX itself has no problem handling colons.
however due to some weird bug, par2 decides to trim the filename before the last colon.
So on OSX, when par2 reads 20:30:40.rar it will expect the file 40.rar.

Anyway, I'll change SABnzbd to mimic the odd behaviour of par2 (0.5.5Final).

Linux users are not affected by this issue.
Post Reply