Some failed jobs not showing as failed in history

Report & discuss bugs found in SABnzbd
Forum rules
Help us help you:
  • Are you using the latest stable version of SABnzbd? Downloads page.
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
Post Reply
hugepants
Newbie
Newbie
Posts: 14
Joined: May 26th, 2013, 5:16 am

Some failed jobs not showing as failed in history

Post by hugepants »

I have set up post-processing python scripts to detect and handle failed downloads.
'Post-Process Only Verified Jobs' is unticked, and 'empty_postproc' is ticked.

When the job appears in the history section, I assume that failed jobs (for any reason) should show as failed with the red skull icon.

In the following cases, they do:
» Aborted, cannot be completed
» Repair failed, not enough repair blocks
» Aborted, encryption detected

However in the next case, they don't, and shows the 'successful' star icon instead:
» Unpacking failed, CRC error

In all four cases, SABnzbd correctly passes a non-zero value to the script for parameter number 7. So I'm able to take appropriate action for failed jobs, but they don't always show as failed in the history, regardless of the exit code I choose to return from the script.

[Version 0.7.11 on Linux]
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Some failed jobs not showing as failed in history

Post by shypike »

The exit code of the script is not used to determine the result of the download.
Is there any pattern detectable in the relation between CRC error and the job end status?
hugepants
Newbie
Newbie
Posts: 14
Joined: May 26th, 2013, 5:16 am

Re: Some failed jobs not showing as failed in history

Post by hugepants »

I wasn't able to find any patterns so I decided to retry the downloads on a different machine with the same config (running Windows).
In the cases where I previously got 'Unpacking failed, CRC error' in Linux, I now get 'Repair failed, not enough repair blocks', and the job shows as failed in the history.

I noticed that the Linux machine had the classic version of par2 0.4, so I switched to the multicore TBB version by chuchusoft. It now behaves exactly like the Windows machine.

I tried both par2-classic and par2 multicore in Windows, and they both produce the same results (correct fail status in history).
I have not since encountered a CRC error, so I cannot yet confirm whether the final job status is marked as failed or not for these types of errors.

I'm happy with how things stand at the moment, with all failed downloads (so far) showing as failed in the history using the par2 multicore on Linux.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Some failed jobs not showing as failed in history

Post by shypike »

Unfortunately we have no control over par2 (and unrar) on Linux systems.
Post Reply