Post processing was aborted...

[FCrane]

Hi!

I'm getting "Post processing was aborted (see logfile)" for ALL downloads. I've attached the part of the logfile for a test download. The download however seems fine, although the "_UNPACK" prefix is not removed. Also, the __ADMIN__ folder is not removed form the incompletes directory either.

This seems to have started when I disabled the option "enable_recursive", because this caused a lot of problems with many downloads.

There's something really broken with Sabnzbd - please fix this. I've tried v0.7.16 and 0.7.17 - it's always the same.

Regards!

Code: Select all

2014-05-11 22:06:21,454::INFO::[assembler:88] Decoding T:\Sabnzbd\incomplete\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-2014.par2 yenc
2014-05-11 22:06:27,506::INFO::[__init__:917] Saving data for totals9.sab in T:\Sabnzbd\admin\totals9.sab
2014-05-11 22:06:27,507::INFO::[assembler:88] Decoding T:\Sabnzbd\incomplete\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-2014.rar yenc
2014-05-11 22:06:27,569::INFO::[__init__:906] T:\Sabnzbd\incomplete\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201\__ADMIN__\SABnzbd_nzo_skgnmt removed
2014-05-11 22:06:27,569::INFO::[nzbqueue:211] Saving queue
2014-05-11 22:06:27,569::INFO::[__init__:917] Saving data for queue9.sab in T:\Sabnzbd\admin\queue9.sab
2014-05-11 22:06:27,569::INFO::[postproc:85] Saving postproc queue
2014-05-11 22:06:27,569::INFO::[__init__:917] Saving data for postproc1.sab in T:\Sabnzbd\admin\postproc1.sab
2014-05-11 22:06:27,576::INFO::[postproc:281] Starting PostProcessing on Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201 => Repair:True, Unpack:True, Delete:True, Script:None, Cat:*
2014-05-11 22:06:28,078::INFO::[postproc:564] Par2 check starting on Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201
2014-05-11 22:06:28,078::INFO::[__init__:872] T:\Sabnzbd\incomplete\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201\__ADMIN__\__verified__ missing
2014-05-11 22:06:28,078::INFO::[postproc:585] Running repair on set Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-2014
2014-05-11 22:06:28,078::INFO::[newsunpack:837] Quick-check for Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-2014 is OK, skipping repair
2014-05-11 22:06:28,078::INFO::[newsunpack:899] Deleting T:\Sabnzbd\incomplete\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-2014.par2
2014-05-11 22:06:28,079::INFO::[postproc:612] Par2 check finished on Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201
2014-05-11 22:06:28,079::INFO::[misc:789] Creating directories: D:\Download\Finished\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201
2014-05-11 22:06:28,081::INFO::[postproc:346] Running unpack_magic on Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201
2014-05-11 22:06:28,081::INFO::[newsunpack:211] Unrar starting on T:\Sabnzbd\incomplete\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201
2014-05-11 22:06:28,081::INFO::[newsunpack:427] Extracting rarfile T:\Sabnzbd\incomplete\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-2014.rar (belonging to Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-2014) to D:\Download\Finished\_UNPACK_Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201
2014-05-11 22:06:28,082::INFO::[newsunpack:496] Read 2 passwords from file T:\Sabnzbd\Passwords.txt
2014-05-11 22:06:28,371::INFO::[newsunpack:730] Unpacked 3 files/folders in 0 seconds
2014-05-11 22:06:28,371::INFO::[newsunpack:451] Deleting T:\Sabnzbd\incomplete\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-2014.rar
2014-05-11 22:06:28,371::INFO::[newsunpack:215] Unrar finished on T:\Sabnzbd\incomplete\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201
2014-05-11 22:06:28,372::ERROR::[postproc:504] Post Processing Failed for Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201 ()
2014-05-11 22:06:28,372::INFO::[postproc:506] Traceback: 
Traceback (most recent call last):
  File "sabnzbd\postproc.pyo", line 347, in process_job
  File "sabnzbd\newsunpack.pyo", line 240, in unpack_magic
UnboundLocalError: local variable 'new_joins' referenced before assignment
2014-05-11 22:06:28,884::INFO::[postproc:537] Cleaning up Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201 (keep_basic=True)
2014-05-11 22:06:28,884::INFO::[__init__:906] T:\Sabnzbd\incomplete\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201\__ADMIN__\SABnzbd_nzf_heol4w removed
2014-05-11 22:06:28,885::INFO::[__init__:906] T:\Sabnzbd\incomplete\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201\__ADMIN__\SABnzbd_nzf_9wszgw removed
2014-05-11 22:06:28,885::INFO::[misc:1300] Cannot remove folder T:\Sabnzbd\incomplete\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201\__ADMIN__
2014-05-11 22:06:28,887::INFO::[misc:1300] Cannot remove folder T:\Sabnzbd\incomplete\Sat Empfang - Testmagazin fuer Satelliten- u Kabelempfang 03-201\__ADMIN__
2014-05-11 22:06:28,888::INFO::[postproc:85] Saving postproc queue
2014-05-11 22:06:28,888::INFO::[__init__:917] Saving data for postproc1.sab in T:\Sabnzbd\admin\postproc1.sab
2014-05-11 22:06:28,888::INFO::[downloader:246] Post-processing finished, resuming download

[sander]

Some remarks:

"There's something really broken with Sabnzbd " ... that tone doesn't invite me to help. Anyway:

"I'm getting "Post processing was aborted (see logfile)" ": I don't see it in your logfile. And AFAIK it should be of the format: ('PostProcessing was aborted (%s)') % unicoder(crash_msg) ... so where is that logging?
"This seems to have started when I disabled the option "enable_recursive"": so ... does this download go well if you enable it again?
You save to T:\ ... that's probably a NAS drive? If so, what happens when you save to C: ?

I found this logging interesting:

Code: Select all

2014-05-11 22:06:28,372::INFO::[postproc:506] Traceback: 
Traceback (most recent call last):
  File "sabnzbd\postproc.pyo", line 347, in process_job
  File "sabnzbd\newsunpack.pyo", line 240, in unpack_magic
UnboundLocalError: local variable 'new_joins' referenced before assignment

... I checked newsunpack.py, and if "cfg.enable_filejoin()" is false, new_joins is indeed not set, which can lead to this message. Which is AFAIK a bug in the code.

[FCrane]

Hi!

Sorry if the tone was not right - English is not my native language...

I just tried reenabling "enable_recursive" and indeed, the problem is gone. However, recursive unpacking causes a lot of problems for many downloads, so I'd prefer switching it off.

The message "Post processing was aborted (see logfile)" is displayed in the Plush skin in the "History" and the log file does not contain any further information (Icopied everything related to that test download into my last message).

Regards!

[sander]

I'm not yet 100% sure whether the Traceback "UnboundLocalError: local variable 'new_joins' referenced before assignment" causes the "PostProcessing was aborted", but it looks so: "Running unpack_magic on" is in your log file, but "unpack_magic finished" is not, so that is an indication the "except" in line 503 of postproc.py is triggered from there, which prints "Post Processing Failed for"

That would mean the "'new_joins' referenced before assignment" must be solved first, and AFAIK that's bug in the SAB code.

Let's wait for Shypike's feedback.

[shypike]

I will handle your patch as soon as I'm ready syncing the "0.7.x" and the "develop" branches.
It sure sound like a bug, only I don't know when it is triggered/

[sander]

@FCrane, FYI: Shypike has confirmed the bug here: https://github.com/sabnzbd/sabnzbd/issu ... t-42985639

Yes, I see the problem.
It happens in two places. I'll fix it asap.

EDIT:
Shypike has fixed it in the git code: https://github.com/sabnzbd/sabnzbd/comm ... 483dd87974

AFAIK this means it will be in the next version of SABnzbd (0.7.18?)

[shypike]

AFAIK this means it will be in the next version of SABnzbd (0.7.18?)

Yes.