"Save Changes" needs to be clicked - even if change was reversed

Report & discuss bugs found in SABnzbd
Forum rules
Help us help you:
  • Are you using the latest stable version of SABnzbd? Downloads page.
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
Post Reply
User avatar
OneCD
Hero Member
Hero Member
Posts: 557
Joined: March 4th, 2017, 3:47 pm

"Save Changes" needs to be clicked - even if change was reversed

Post by OneCD »

Hello,

Now running my nice new SAB 2.3.0 and it's looking good so far. ;D

But noticed a small issue: if I'm on a config page - say 'Switches' - and tick a box, then untick that same box, the page seems to see this as a config change and throws the warning about "This page is asking you to confirm that you want to leave - data you have entered may not be saved" with the "Stay on Page" and "Leave Page" buttons available.

To prevent this, I need to click on a "Save Changes" button before leaving this page, even though I reversed my change.

I guess for the browser to recognise this, it would need to keep track of the state of every field on that page, then compare each one when attempting to leave that page. If the finished-state is the same as the load-state, then saving would not be required.

Thoughts?
Stuff I like: Apache bash cron DD-WRT Debian DNSMasq Entware FireFox GitHub ImageMagick Kate KDE LibreELEC Netrunner NFS NVIDIA OpenVPN Orvibo-S20 pfSense Python Raspberry-Pi RAID SABnzbd Transmission Usenet VirtualBox Watcher3 XFCE
User avatar
safihre
Administrator
Administrator
Posts: 5339
Joined: April 30th, 2015, 7:35 am
Contact:

Re: "Save Changes" needs to be clicked - even if change was reversed

Post by safihre »

You are right, but that would involve either putting the original value in a html-attribute or save the initial state on page load with some JS magic.
If you want to implement that, it would be nice to have :) ;)
If you like our support, check our special newsserver deal or donate at: https://sabnzbd.org/donate
User avatar
OneCD
Hero Member
Hero Member
Posts: 557
Joined: March 4th, 2017, 3:47 pm

Re: "Save Changes" needs to be clicked - even if change was reversed

Post by OneCD »

Afraid my web-dev skills are stuck back in the mid 1990's with static pages. ::)
Stuff I like: Apache bash cron DD-WRT Debian DNSMasq Entware FireFox GitHub ImageMagick Kate KDE LibreELEC Netrunner NFS NVIDIA OpenVPN Orvibo-S20 pfSense Python Raspberry-Pi RAID SABnzbd Transmission Usenet VirtualBox Watcher3 XFCE
Post Reply