Unpacking directly to folder?

Report & discuss bugs found in SABnzbd
Forum rules
Help us help you:
  • Are you using the latest stable version of SABnzbd? Downloads page.
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
Post Reply
herkalurk
Newbie
Newbie
Posts: 7
Joined: September 5th, 2016, 12:38 am

Unpacking directly to folder?

Post by herkalurk »

I was watching the processes as sab was unpacking some releases I downloaded. I have some SMB mounts that are used with the categories for directly placing the files on network shares. While sab was unpacking a 7z archive I noticed that it copied the file out to the destination, then unpacked locally. Wouldn't it make more sense to leave the archive files in the temporary download folder, and directly unpack to the _UNPACK directory? You're transferring the archive to then unpack there making more I/O.

Code: Select all

/usr/libexec/p7zip/7za x -y -aou -t7z -ssc -p -o/media/tv/Taskmaster/S01/_UNPACK_Taskmaster.S01E05.720p.HDTV.x264-Cherzo /media/tv/Taskmaster/S01/_UNPACK_Taskmaster.S01E05.720p.HDTV.x264-Cherzo/415b07ed270c44aba3068b2c9dd7d40d.7z

User avatar
safihre
Administrator
Administrator
Posts: 3979
Joined: April 30th, 2015, 7:35 am
Location: Switzerland
Contact:

Re: Unpacking directly to folder?

Post by safihre »

We (should) only do that for recursive unpacks, so when the original files inside the NZB after the first unpacking contain even more archives inside of them.
Was that the case for this job? What were the original files inside the NZB? Were they maybe .001, .002, etc files?
If you like our support, check our special newsserver deal or donate at: https://sabnzbd.org/donate

herkalurk
Newbie
Newbie
Posts: 7
Joined: September 5th, 2016, 12:38 am

Re: Unpacking directly to folder?

Post by herkalurk »

It was a multipart before unpacking

Code: Select all

1	415b07ed270c44aba3068b2c9dd7d40d [1/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.001" yEnc (1/14)	100%	51.27 MB
2	415b07ed270c44aba3068b2c9dd7d40d [2/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.002" yEnc (1/14)	100%	51.27 MB
3	415b07ed270c44aba3068b2c9dd7d40d [3/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.003" yEnc (1/14)	100%	51.27 MB
4	415b07ed270c44aba3068b2c9dd7d40d [4/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.004" yEnc (1/14)	100%	51.27 MB
5	415b07ed270c44aba3068b2c9dd7d40d [5/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.005" yEnc (1/14)	100%	51.27 MB
6	415b07ed270c44aba3068b2c9dd7d40d [6/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.006" yEnc (1/14)	100%	51.27 MB
7	415b07ed270c44aba3068b2c9dd7d40d [7/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.007" yEnc (1/14)	100%	51.27 MB
8	415b07ed270c44aba3068b2c9dd7d40d [8/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.008" yEnc (1/14)	100%	51.27 MB
9	415b07ed270c44aba3068b2c9dd7d40d [9/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.009" yEnc (1/14)	100%	51.27 MB
10	415b07ed270c44aba3068b2c9dd7d40d [10/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.010" yEnc (1/14)	100%	51.27 MB
11	415b07ed270c44aba3068b2c9dd7d40d [11/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.011" yEnc (1/14)	100%	51.27 MB
12	415b07ed270c44aba3068b2c9dd7d40d [12/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.012" yEnc (1/14)	100%	51.27 MB
13	415b07ed270c44aba3068b2c9dd7d40d [13/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.013" yEnc (1/14)	100%	51.27 MB
14	415b07ed270c44aba3068b2c9dd7d40d [14/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.014" yEnc (1/14)	100%	51.27 MB
15	415b07ed270c44aba3068b2c9dd7d40d [15/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.015" yEnc (1/14)	100%	51.27 MB
16	415b07ed270c44aba3068b2c9dd7d40d [16/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.016" yEnc (1/14)	100%	51.27 MB
17	415b07ed270c44aba3068b2c9dd7d40d [17/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.017" yEnc (1/14)	100%	51.27 MB
18	415b07ed270c44aba3068b2c9dd7d40d [18/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.018" yEnc (1/14)	100%	51.27 MB
19	415b07ed270c44aba3068b2c9dd7d40d [19/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.019" yEnc (1/14)	100%	51.27 MB
20	415b07ed270c44aba3068b2c9dd7d40d [20/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.020" yEnc (1/14)	100%	51.27 MB
21	415b07ed270c44aba3068b2c9dd7d40d [21/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.021" yEnc (1/14)	100%	51.27 MB
22	415b07ed270c44aba3068b2c9dd7d40d [22/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.022" yEnc (1/14)	100%	51.27 MB
23	415b07ed270c44aba3068b2c9dd7d40d [23/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.023" yEnc (1/14)	100%	51.27 MB
24	415b07ed270c44aba3068b2c9dd7d40d [24/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.024" yEnc (1/14)	100%	51.27 MB
25	415b07ed270c44aba3068b2c9dd7d40d [25/32] "415b07ed270c44aba3068b2c9dd7d40d.7z.025" yEnc (1/10)	100%	33.22 MB
26	415b07ed270c44aba3068b2c9dd7d40d [26/32] "415b07ed270c44aba3068b2c9dd7d40d.par2" yEnc (1/1)	par2	100%	13.2 KB
27	415b07ed270c44aba3068b2c9dd7d40d [27/32] "415b07ed270c44aba3068b2c9dd7d40d.vol00+01.par2" yEnc (1/2)	par2	100%	3.68 MB
28	415b07ed270c44aba3068b2c9dd7d40d [28/32] "415b07ed270c44aba3068b2c9dd7d40d.vol01+02.par2" yEnc (1/3)	par2	100%	7.34 MB
29	415b07ed270c44aba3068b2c9dd7d40d [29/32] "415b07ed270c44aba3068b2c9dd7d40d.vol03+04.par2" yEnc (1/5)	par2	100%	14.67 MB
30	415b07ed270c44aba3068b2c9dd7d40d [30/32] "415b07ed270c44aba3068b2c9dd7d40d.vol07+08.par2" yEnc (1/9)	par2	100%	29.34 MB
31	415b07ed270c44aba3068b2c9dd7d40d [31/32] "415b07ed270c44aba3068b2c9dd7d40d.vol15+16.par2" yEnc (1/17)	par2	100%	58.65 MB
32	415b07ed270c44aba3068b2c9dd7d40d [32/32] "415b07ed270c44aba3068b2c9dd7d40d.vol31+04.par2" yEnc (1/5)	par2	100%	14.67 MB

User avatar
safihre
Administrator
Administrator
Posts: 3979
Joined: April 30th, 2015, 7:35 am
Location: Switzerland
Contact:

Re: Unpacking directly to folder?

Post by safihre »

Indeed that's a special case where we first have to combine them and only then unpack. That's the only exception to the unpacking ritual. Here the combining is the first "unpack". It is due to some older versions of 7zip not supporting this style of split archives.
If you like our support, check our special newsserver deal or donate at: https://sabnzbd.org/donate

herkalurk
Newbie
Newbie
Posts: 7
Joined: September 5th, 2016, 12:38 am

Re: Unpacking directly to folder?

Post by herkalurk »

Do you have logic to do the faster part unpack with newer versions? If so what minimum version should I have to make sure it will do the multi part unpack?

User avatar
safihre
Administrator
Administrator
Posts: 3979
Joined: April 30th, 2015, 7:35 am
Location: Switzerland
Contact:

Re: Unpacking directly to folder?

Post by safihre »

No, we just always do it like that. The code is very old, so we would have to investigate if the 7zip issue is still present or we can remove this workaround from the code.
If you like our support, check our special newsserver deal or donate at: https://sabnzbd.org/donate

Post Reply