Page 1 of 1

issue warning when external script is not executable?

Posted: January 13th, 2019, 5:46 pm
by OneCD
Hello,

I've just been caught-out by this again. :(

I'm trying a new external Python post-processing script, and I forgot to set the executable bits on it. I was able to select this script via the SAB UI but SAB didn't complain until it attempted to run the script. It then told me the script wasn't executable.

Would it be possible for SAB to issue a logged warning message when a non-executable script has been selected for a queue item? Maybe this could happen everytime a new queue item is added, or an existing queue item changes post-processing to use an unexecutable script?

Thank you.

Re: issue warning when external script is not executable?

Posted: January 15th, 2019, 1:55 am
by safihre
Sure, we can do that. Let me check.

Re: issue warning when external script is not executable?

Posted: January 15th, 2019, 3:02 am
by safihre
Oke maybe it's harder than I thought, since post-proc scripts are set in multiple places.

Re: issue warning when external script is not executable?

Posted: January 15th, 2019, 3:16 am
by OneCD
Thanks @safihre.

What if the choice of listed scripts shows only the executable ones? Then the user wouldn’t be able to select a non-executable script.

Re: issue warning when external script is not executable?

Posted: January 15th, 2019, 3:30 am
by safihre
That would be possible, but would that not be confusing?

Re: issue warning when external script is not executable?

Posted: January 15th, 2019, 3:43 am
by OneCD
Well, it may lead to support questions like “why can’t SABnzbd see my script?

Then my first question would be “is it executable?;)