Page 1 of 1

Sample deletion as before

Posted: June 14th, 2019, 4:25 pm
by ErikBrown
Hi,

The deletion of samples has been changed in version 2.3.9 as per the change log. But now I get lots of sample files. Would it be possible to make it optional to delete the files again as before so that the user can decide to automatically remove all the files with sample in the name or not?

Thanks,
Erik

Re: Sample deletion as before

Posted: June 15th, 2019, 4:37 am
by pxr5
I've started to get samples coming back too. The above would be useful.

Re: Sample deletion as before

Posted: June 15th, 2019, 6:29 am
by safihre
Could you send me example NZBs where you are getting too many samples?
It should only not delete them if all files contain the word "sample" or "proof" or in case there's only 1 file.

Re: Sample deletion as before

Posted: June 15th, 2019, 10:53 am
by ErikBrown
Hi Safihre,

I have emailed you at your personal email address at sabnzbd dot org some NZBs that cause sample files not to be deleted.

Regards,
Erik

Re: Sample deletion as before

Posted: June 16th, 2019, 10:40 am
by pxr5
Hi safihre,

I've emailed you one as well.

Re: Sample deletion as before

Posted: June 17th, 2019, 12:55 am
by safihre
Found the issue with your NZB's.
Bad testing on my part, didn't test the case with just 1 sample file.

Re: Sample deletion as before

Posted: June 17th, 2019, 3:51 am
by ErikBrown
Thanks for fixing it!

Re: Sample deletion as before

Posted: June 17th, 2019, 6:40 am
by pxr5
Thanks from me too :-)

Re: Sample deletion as before

Posted: August 17th, 2019, 1:02 pm
by osen
Sorry for bumping this thread, but what was the fix for this? I'm on latest release (2.3.9) and I'm experiencing this problem. Do I have to build from source to get the fix?

Re: Sample deletion as before

Posted: August 18th, 2019, 2:34 am
by jcfp
osen wrote:
August 17th, 2019, 1:02 pm
Sorry for bumping this thread, but what was the fix for this? I'm on latest release (2.3.9) and I'm experiencing this problem. Do I have to build from source to get the fix?
https://github.com/sabnzbd/sabnzbd/comm ... 8083b36548

There's no release yet that includes that commit though.

Re: Sample deletion as before

Posted: August 18th, 2019, 9:38 am
by osen
jcfp wrote:
August 18th, 2019, 2:34 am
osen wrote:
August 17th, 2019, 1:02 pm
Sorry for bumping this thread, but what was the fix for this? I'm on latest release (2.3.9) and I'm experiencing this problem. Do I have to build from source to get the fix?
https://github.com/sabnzbd/sabnzbd/comm ... 8083b36548

There's no release yet that includes that commit though.
I see. Successfully installed from source and sample deletion does indeed seem to be working again. I read the first post too fast, didn't notice this "bug" was introduced in 2.3.9 so I guess simply downgrading to 2.3.8 for the time being would be a lot more convenient.

Thank you very much.