PAR2 issues with multiple set of par in one nzb

[sbultez]

Hello,
I just downloaded one post (NZBID 2943270)
I faced TWO problem :
Click for full size - Uploaded with plasq's Skitch

-----------1----------

Problem is that there is ONE wrong par2 file included in the report (it's episode 10, not 9).
SABnzbd just tries to download this particular PAR2 file, and thus fails to verify/unrar (i enabled the option to stop processing if par2 fails).

SAB should be smarter, and download all the par2 index files (not the verification blocks, just the index files), and then check the archive with all of these par2 index files ! (in this case, the report contains PAR2 index for episode 9 and 10, and more than enough episode 10 blocks to repair it without any problem !)

Funny thing is that these rar had 0 problem, but the whole thing seemed to have completely failed at first.
I had to download par2 files separately (because SAB did not download any), and check manually.

-----------2----------

To check that faster, I tried to download only the episode 10 par2 index file (no repair blocks)
Downloadind that single file failed with this error message (the queued item would stay indefinitely0 - using Mac OSX, SVN from yesterday night, python 2.5.1

008-04-10 12:58:47,902::ERROR::[sabnzbd] Error accessing NZBQ?
Traceback (most recent call last):
  File "/Applications/SAB/main/sabnzbd/__init__.py", line 729, in register_article
    return NZBQ.register_article(article)
  File "/Applications/SAB/main/sabnzbd/decorators.py", line 26, in newFunction
    return f(*args, **kw)
  File "/Applications/SAB/main/sabnzbd/nzbqueue.py", line 346, in register_article
    file_done, post_done, reset = nzo.remove_article(article)
  File "/Applications/SAB/main/sabnzbd/nzbstuff.py", line 544, in remove_article
    self.set_download_report()
  File "/Applications/SAB/main/sabnzbd/nzbstuff.py", line 609, in set_download_report
    avgspeed = (self.__bytes / 1024) / totaltime
ZeroDivisionError: integer division or modulo by zero

To finally solve that whole problem, I had to download the whole par2 set fr episode 10, which finally worked.

-----------------

Request : FAILED downloads should be in a FAILED directory. Because in that case, as I am using TV show sorting  season folders, No folders, The whole RAR set + the wrong episode 9 par2 index file landed in the middle of my other episodes ...

-----------------

Do you guys mind have a look at those two bugs ?

Thanks,

Sam

[shypike]

The crash will be fixed.

As for the incorrect par2 file. What you suggest is impossible.
SABnzbd cannot know that the par2 file does not belong to the set.
It might be that some files could not be downloaded.
Each par2-set is verified and if one fails, the job is flagged as failed.
In a next release it will go into a _FAILED_ folder, for manual inspection and repair.

Given the lack of quality of some NZB files we get sent, it's no wonder
that SABnznd does not lways do what you expect.

If you have less than kosher NZB files, do not use the "safe postproc" option.
It will then try to unpack anyway and you will be the judge.

BTW: The TV season sorter will get some improvements too.

[sbultez]

thanks :-)
I agree with you, this nzb report with wrong parset is an exception !