Beta4 par2 failure

[jack42]

Apologies, but I'm not in a position to be able to test this on B5, but I couldn't see it in the release notes, so it may well still happen.

I recently had a par2 repair fail in apparently a rather silly way. The nzb contained 2 separate par sets, one for the main file and one for the sample. SAB verified the main set, found that it needed repairing, repaired it, then deleted the par files. Unfortunately it seems that while the way it decided upon the set of par files to use was not the same as the way it decided upon those to delete, as it also deleted the sample par files as well. Then it tried to verify the sample par set and failed, because it had already deleted them! This failure cause the job to fail unnecessarily, meaning it didn't get unrared and it got labled FAILED in the done directory. To avoid this I would guess that either the wildcard pattern for the delete command should be tweaked so that it only deletes the set that has finished repairing, or all the deleting should only be done at the end when and if all repairing has completed successfully.

Here are the relevant log lines, modified for publication.

2008-05-17 15:50:02,340::INFO::[postproc] Starting PostProcessing on ReportName.nzb => Repair:True, Unpack:True, Delete:True, Script:None
2008-05-17 15:50:02,343::INFO::[postproc] Par2 check starting on ReportName.nzb
2008-05-17 15:50:02,343::INFO::[postproc] Running repair on set FileName
2008-05-17 15:51:03,397::INFO::[newsunpack] Par verify finished ok on /path/incomplete/ReportName/FileName.vol00+01.par2!
2008-05-17 15:51:03,409::INFO::[newsunpack] Deleting /path/incomplete/ReportName/FileName.par2
2008-05-17 15:51:03,419::INFO::[newsunpack] Deleting /path/incomplete/ReportName/FileName.vol00+01.par2
2008-05-17 15:51:03,453::INFO::[newsunpack] Deleting /path/incomplete/ReportName/FileName.SAMPLE.vol000+01.par2
2008-05-17 15:51:03,468::INFO::[newsunpack] Deleting /path/incomplete/ReportName/FileName.SAMPLE.vol001+02.par2
2008-05-17 15:51:03,469::INFO::[newsunpack] Deleting /path/incomplete/ReportName/FileName.SAMPLE.vol003+04.par2
2008-05-17 15:51:03,470::INFO::[newsunpack] Deleting /path/incomplete/ReportName/FileName.SAMPLE.vol007+08.par2
2008-05-17 15:51:03,473::INFO::[newsunpack] Deleting /path/incomplete/ReportName/FileName.SAMPLE.par2
2008-05-17 15:51:03,474::INFO::[postproc] Running repair on set FileName.SAMPLE
2008-05-17 15:51:03,689::INFO::[newsunpack] Par verify failed on /path/incomplete/ReportName/FileName.SAMPLE.vol000+01.par2!
2008-05-17 15:51:03,690::INFO::[postproc] Par2 check finished on ReportName.nzb
2008-05-17 15:51:03,714::INFO::[sabnzbd.misc] Creating directories: /path.done/ReportName
2008-05-17 15:51:03,814::INFO::[postproc] Cleaning up ReportName.nzb

I have had other similar nzbs complete fine, but unfortunately I don't still have the log detail for those to compare the order of operations (as they have been rotated out). It's possible there were differences in the ordering within the nzb file, and which of the par sets needed repairing as opposed to simply verifying correctly may have made a difference.

I can email the nzb if needed.

[shypike]

Please send the NZB file to bugs at sabnzbd.org