[FIXED] 0.4.0b2 does not remove blackhole files

Questions and bug reports for Beta releases should be posted here.
Forum rules
Help us help you:
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
Sypher
Release Testers
Release Testers
Posts: 75
Joined: April 10th, 2008, 10:23 am

Re: 0.4.0b2 does not remove blackhole files

Post by Sypher »

Yeah well, nevertheless this did work in 0.3.x releases, and I can delete them manually so I don't see why SABnzbd can't.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: 0.4.0b2 does not remove blackhole files

Post by shypike »

Sypher wrote: Yeah well, nevertheless this did work in 0.3.x releases, and I can delete them manually so I don't see why SABnzbd can't.
Neither do I, but it's a bit hard to diagnose from here.
Look, the logging shows that the correct path is used to delete, the delete is just a simple
call to the Python library, which does a Windows delete.
I can find no problem

The directory scan code has been modified again for the coming Beta3 (for some extra functionality),
so maybe you will get lucky with Beta3.
Sypher
Release Testers
Release Testers
Posts: 75
Joined: April 10th, 2008, 10:23 am

Re: 0.4.0b2 does not remove blackhole files

Post by Sypher »

I will have a look and hope that it works again..
It's not "full-auto" if you have to remove the files every time manually is it? :)
Sypher
Release Testers
Release Testers
Posts: 75
Joined: April 10th, 2008, 10:23 am

Re: 0.4.0b2 does not remove blackhole files

Post by Sypher »

Ok; strange addition.
When I download a NZB file from a site like Binsearch, it produces a nice .nzb file.
I use Sabnzbdmove so it immediately goes into the blackhole folder.

When I do this, SABnzbd can't remove it.

But: When I download a ZIP or RAR file with the .nzb in it, and I double click it so that Sabnzbdmove moves it.... SABnzbd can remove it.
Seems really flaky, this normally worked 100%
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: 0.4.0b2 does not remove blackhole files

Post by shypike »

Most likely explanation is that Sabnzbdmove doesn't properly close files.
Windows won't allow you to delete a file while other programs still claim it.
Please complain to the author of Sabnzbdmove.
AllRoCol
Newbie
Newbie
Posts: 10
Joined: April 22nd, 2008, 11:58 pm

Re: 0.4.0b2 does not remove blackhole files

Post by AllRoCol »

It is still happening on beta 4 for me. Only when .nzb files are read only, which some programs make them into. If I uninstall those programs, everything goes back to normal and they can be deleted.

Is there any way to get sabnzbd to erase read only files?
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: 0.4.0b2 does not remove blackhole files

Post by shypike »

AllRoCol wrote: Is there any way to get sabnzbd to erase read only files?
Of course there is, but read-only files are just that: "read-only".
I don't think SABnzbd should ignore this "protection".
Try to tackle the problem where it's caused: and that is not in SABnzbd.

You could use the user-script solution of course, as suggested by pairofdimes.
Sypher
Release Testers
Release Testers
Posts: 75
Joined: April 10th, 2008, 10:23 am

Re: 0.4.0b2 does not remove blackhole files

Post by Sypher »

A script is possible yeah, but isn't it possible to add some kind of featuer in SABnzbd that retries when it fails?

Failed,  wait 5 seconds, try again. If all fails 3 times: give back an error.
AllRoCol
Newbie
Newbie
Posts: 10
Joined: April 22nd, 2008, 11:58 pm

Re: 0.4.0b2 does not remove blackhole files

Post by AllRoCol »

So 2 or more programs out there force nzb files to be read only. These programs are rarely, if ever updated. The solution is to have every user make a script?

Other options perhaps:
#1- We try to locate the programmers and force them to change it. Possible, but unlikely looking at the programs and their support systems.
#2- We request the feature to import nzbs built into Sabnzbd plus. Seems like a reasonable feature. I mean you can open nzb files from the web with other programs, like newsleecher and alt.binz, so why not? Even if it was a separately programmed feature.
#3- You build in the capability to delete read only files, optionally. I wouldn't exactly call it a break of windows protection to delete read only .nzb files if we wanted to. Leave it off by default, of course.

I don't know. I mean it is useful to have the ability to auto add .nzb files from other sites. For example, nzbmatrix is updated a little faster than newzbin, so if I am sitting around waiting for a file I typically end up getting it from there. Sabtab doesn't work there, so I have to manually add it to my blackhole folder. If I use another program, I just have it open in that program. Definitely something I would like to see in Sabnzbd.

Just my thoughts. They aren't even worth 2 cents.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: 0.4.0b2 does not remove blackhole files

Post by shypike »

SABnzbd has enough import options.

I cannot think of any good reason why an other program would create read-only files.
If the files are read-only for other reasons, there's no way SABnzbd can remove them.
Windows simply pervents deletion of files that are "in use" by other programs.

As for sabnzbdmove: what is is? I cannot find this program.
We don't intend to support add-ons that aren't even maintained properly by their authors.
Just don't use them.
Plenty of alternatives are available.
AllRoCol
Newbie
Newbie
Posts: 10
Joined: April 22nd, 2008, 11:58 pm

Re: 0.4.0b2 does not remove blackhole files

Post by AllRoCol »

shypike wrote: SABnzbd has enough import options.

I cannot think of any good reason why an other program would create read-only files.
If the files are read-only for other reasons, there's no way SABnzbd can remove them.
Windows simply pervents deletion of files that are "in use" by other programs.

As for sabnzbdmove: what is is? I cannot find this program.
We don't intend to support add-ons that aren't even maintained properly by their authors.
Just don't use them.
Plenty of alternatives are available.
I was talking about open, not move. I don't know what he is talking about. Open is found on this forums third party apps list.

So ok, no plans to implement direct from browser .nzb support. Fine, I'll buy this. Now let me ask you how you would do it? Say you used another .nzb site (Other than newzbin). What is the fastest way for you to get the .nzb file to sabnzbd?

Open leaves them read only. Gui is buggy and I haven't used it much since the old sabnzbd.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: 0.4.0b2 does not remove blackhole files

Post by shypike »

What I use is this trick:

http://sabnzbd.wikidot.com/howto-associate
AllRoCol wrote: So ok, no plans to implement direct from browser .nzb support.
This is really outside SABnzbd. This can only be done by writing a plugin for Firefox (or a GreaseMonkey script).
I have no idea how to do it for IE or Opera.
Outside my knowledge area, but I'm happy to adopt such a script if somebody wants to create it.
Sypher
Release Testers
Release Testers
Posts: 75
Joined: April 10th, 2008, 10:23 am

Re: 0.4.0b2 does not remove blackhole files

Post by Sypher »

Problem looks solved in the latest beta. Maybe since b3.

Either way, my blackhole files are removed again :)
azrael_tv
Newbie
Newbie
Posts: 2
Joined: June 22nd, 2008, 8:50 am

Re: [FIXED] 0.4.0b2 does not remove blackhole files

Post by azrael_tv »

FYI, I just use a lil .cmd script to move nzb to sabs blackhole, is set as default firefox open action for nzb (configured nb so i get uncompressed nzb files):

move %1 E:\SAB\NZB_blackhole

thats all..
Post Reply