Page 2 of 3

Re: Disk error on creating file

Posted: October 25th, 2017, 4:08 am
by safihre
Received the log, it was a racing condition that can occur for very small downloads.
Will fix for 2.3.1.

Re: Disk error on creating file

Posted: October 26th, 2017, 4:43 pm
by tranx
Hi, this just happened, and now I had the DEBUG enabled.

My suspicion was correct, the directory is removed, and then yenc is called to decode a par2 file that doesn't exist anymore.

I will upload the log file in a bit

EDIT: Oh, I just realized you already know what the issue is :)

Thanks!

Re: Disk error on creating file

Posted: October 26th, 2017, 7:19 pm
by tranx
Please let me know if you still need the log. Looking forward to testing 2.3.1..

Re: Disk error on creating file

Posted: October 28th, 2017, 3:03 am
by safihre
2.3.1 is out, let me know if it's fixed! :)

Re: Disk error on creating file

Posted: October 29th, 2017, 10:52 am
by tranx
Sure thing, thanks a lot.

Re: Disk error on creating file

Posted: November 7th, 2017, 12:55 am
by MikeC
I seem to be having this still. I am running SABnzbd 2.3.1 [f1695ec] on my Raspberry Pi

From the sabnzbd.log at the time it happens I see the following (I don't have any DEBUG logging or anything set I don't think) :

Code: Select all

2017-11-07 06:04:48,268::INFO::[assembler:96] Decoding /dl/incomplete/downloadname/"GQ4WENDBHAYTQMZQGA2DIYRYGQWEM3E" yEnc (1+1) yenc
2017-11-07 06:04:48,277::ERROR::[assembler:106] Disk error on creating file /dl/incomplete/downloadname/"GQ4WENDBHAYTQMZQGA2DIYRYGQWEM3E" yEnc (1+1)
2017-11-07 06:04:48,283::INFO::[assembler:108] Traceback:
Traceback (most recent call last):
  File "/usr/share/sabnzbdplus/sabnzbd/assembler.py", line 98, in run
    filepath = self.assemble(nzf, filepath)
  File "/usr/share/sabnzbdplus/sabnzbd/assembler.py", line 167, in assemble
    fout = open(path, 'ab')
IOError: [Errno 22] invalid mode ('ab') or filename: u'/dl/incomplete/downloadname/"GQ4WENDBHAYTQMZQGA2DIYRYGQWEM3E" yEnc (1+1)'
2017-11-07 06:04:48,287::INFO::[downloader:277] Pausing
A restart of SABnzbd kicks things back into action.

Let me know if there is more I can provide to be of any help.

Re: Disk error on creating file

Posted: November 7th, 2017, 1:44 am
by hamid313
2.3.1RC2 [770951b]
seems to be fixed
you need to update 1 of the files to include debugging in logs

Re: Disk error on creating file

Posted: November 7th, 2017, 3:09 am
by safihre
That filename is very weird, that looks more like it could be the problem. Although on most Linux systems it shouldn't be a problem.
Maybe turn on Make Windows Compatible in Config Switches to filter out the weirdness.

Re: Disk error on creating file

Posted: November 7th, 2017, 8:04 am
by sander
Indeed a weird filename (with quotes in it ... asking for trouble). On what kind of filesystem is /dl/incomplete/ ? Is it ext3, ext4, btrfs, or ... a FAT or NTFS drive ...

Update:

With https://www.binsearch.info/index.php?q= ... YRYGQWEM3E

No problem downloading the NZB onto my Ext3 filesystem. Resulting file

Code: Select all

-rw-r--r--  1 sander sander   473 nov  7 13:30 'GQ4WENDBHAYTQMZQGA2DIYRYGQWEM3E' yEnc (1+1)
So ... single quotes in the filename ... brrr. But apparently no problem on ext3


But onto my FAT drive I get this message from SABnzbd:

Code: Select all

Disk error on creating file /media/sander/CDB8-59F1/Downloads/incomplete/GQ4WENDBHAYTQMZQGA2DIYRYGQWEM3E/"GQ4WENDBHAYTQMZQGA2DIYRYGQWEM3E" yEnc (1+1)
So ... a filesystem problem / limitation.

More OS/FS details on my FAT drive:

Strangely enough, I can create a filename with a single quote in it:

Code: Select all

sander@sammie-1710:~$ touch "/media/sander/CDB8-59F1/hello with ' blabla.txt"
sander@sammie-1710:~$ 

-rw-r--r--  1 sander sander     0 nov  7 19:33 hello with ' blabla.txt
Other notations, or double quotes, do not work:

Code: Select all

sander@sammie-1710:~$ touch "/media/sander/CDB8-59F1/hello with \' escape blabla.txt"
touch: setting times of '/media/sander/CDB8-59F1/hello with \'\'' escape blabla.txt': No such file or directory
sander@sammie-1710:~$ 
sander@sammie-1710:~$ touch '/media/sander/CDB8-59F1/hello with " double quote blabla.txt'
touch: setting times of '/media/sander/CDB8-59F1/hello with " double quote blabla.txt': No such file or directory
sander@sammie-1710:~$ 
sander@sammie-1710:~$ touch '/media/sander/CDB8-59F1/hello with \" double quote blabla.txt'
touch: setting times of '/media/sander/CDB8-59F1/hello with \" double quote blabla.txt': No such file or directory

Re: Disk error on creating file

Posted: November 8th, 2017, 2:35 am
by MikeC
Thanks for all the replies. I suspected it could be to do with the double quotes.
The filesystem indeed FAT, well vfat (I made it that as I had plans to remove the drive now and then to use elsewhere to move media around, but never ended up doing that, so maybe I should reformat it to ext3)
I have enabled that Make Windows Compatible in Config Switches option and will keep an eye on things for now.

Re: Disk error on creating file

Posted: November 9th, 2017, 3:33 pm
by tranx
Hi, I had this issue happen again on 2.3.1

I am on Linux and it's not a problem with the filename.

The download was a total of 3MB. I have the log with debugging enabled if needed.

Re: Disk error on creating file

Posted: November 10th, 2017, 2:54 am
by safihre
Yes please send the whole log to [email protected].
Currently only intermittently near my computer so will try to inspect the log as soon as time permits! :)

Re: Disk error on creating file

Posted: November 14th, 2017, 11:05 pm
by tranx
Sorry for the delay, I just sent this log to your email. Thanks

Re: Disk error on creating file

Posted: November 15th, 2017, 6:03 am
by safihre
I think I found the spot where the problem is!
Will try to fix for 2.3.2

Re: Disk error on creating file

Posted: November 16th, 2017, 12:12 am
by tranx
Ok, thank you! I am glad that was helpful