Page 1 of 1
Scripts not working
Posted: January 16th, 2024, 1:19 pm
by kallek
Since updating Sabnzbd to 4.2.1 on my Qnap nas, scripts don't work.
When I go to the dropdown list "On queue finish", the only available option is Shutdown SABnzbd. All the other scripts in the scripts folder don't show up. I checked the location of the scripts folder in the folders menu and it is correct (Default). The scripts are still in the folder, so I don't know why they don't show up.
I am not alone to have this problem:
https://forum.qnap.com/viewtopic.php?p=857645#p857645
Re: Scripts not working
Posted: January 16th, 2024, 1:21 pm
by OneCD
#Metoo!
Re: Scripts not working
Posted: January 16th, 2024, 2:13 pm
by safihre
This part of the code didn't change.. We just run a simple listing of the files on your selected folder.
It checks if you have Read permissions and the X bits have been set on the scripts.
https://github.com/sabnzbd/sabnzbd/blob ... em.py#L587
Re: Scripts not working
Posted: January 16th, 2024, 3:50 pm
by OneCD
Just did a test: went back to SABnzbd 4.1.0 (running from source), and it correctly lists my scripts in the same environment 4.2.1 doesn't.
I'll continue checking the later releases and see if I can find out where it stopped working.
Re: Scripts not working
Posted: January 16th, 2024, 4:02 pm
by OneCD
update:
- works in 4.2.0Alpha1
- works in 4.2.0Alpha2
- not working in 4.2.0Alpha3
- not working in 4.2.0Beta1
If filesystem.py hasn't changed, maybe it’s the interface?
Re: Scripts not working
Posted: January 16th, 2024, 4:08 pm
by OneCD
Might be this?
https://github.com/sabnzbd/sabnzbd/comm ... b7f5a7f00a
It looks like 'interfaces/Glitter/templates/include_menu.tmpl' had some changes related to end-of-queue operations.
Re: Scripts not working
Posted: January 16th, 2024, 4:26 pm
by OneCD
Ah, I now realise this selection box was moved from the front SABnzbd page, into Config -> Switches -> Queue -> On queue finish script.
So, not a bug, just a change.
Re: Scripts not working
Posted: January 17th, 2024, 2:53 am
by safihre
It's in the 4.2.0 release notes which is also part of the 4.2.1 release notes
Re: Scripts not working
Posted: January 17th, 2024, 3:07 am
by OneCD
I even post those release notes on the QNAP forum. I should probably read them a little closer though.