safihre wrote:Clearly you skipped over mine, JCFP's and @nahun's first advice:
Use the official tarball releases.
Why would you possibly be pulling from the develop branch for a port/package?
If you keep insisting to go against our advice of using the official releases that everything you need inside, you should use the master branch and of course not the develop branch.
In the master branch we only put stable releases and the version info is set.
The FreeBSD ports systems uses tags when pulling down the source code from github. Since the PORTVERSION in the Makefile is set to 1.2.0 it is using that as the tag name. This is the full URL the ports system is using to download the tarball:
Just use the master branch, we only push there in case of a new stable release. Indeed the tags are on develop, without the version set.
The ports system must be able to just wget or curl a file? Not just git tags?
If you like our support, check our special newsserver deal or donate at: https://sabnzbd.org/donate
safihre wrote:Just use the master branch, we only push there in case of a new stable release. Indeed the tags are on develop, without the version set.
The ports system must be able to just wget or curl a file? Not just git tags?
You can set just a URL to download from using MASTER_SITES, but I think the FreeBSD devs prefer using the github integration when possible.
Looks like the best option is to use the specific commit hash so that it pulls from master and for that specific version. Easy one line change to the Makefile and frequently done in the ports system.
safihre wrote:Clearly you skipped over mine, JCFP's and @nahun's first advice:
Use the official tarball releases.
Why would you possibly be pulling from the develop branch for a port/package?
If you keep insisting to go against our advice of using the official releases that everything you need inside, you should use the master branch and of course not the develop branch.
In the master branch we only put stable releases and the version info is set.
I was not trying to pull from the develop branch just using the tag.
safihre wrote:Just use the master branch, we only push there in case of a new stable release. Indeed the tags are on develop, without the version set.
The ports system must be able to just wget or curl a file? Not just git tags?
Yes, it can fetch any URL we specify like I proposed here. https://bugs.freebsd.org/bugzilla/attac ... ction=diff
I'm just trying to make things as maintainable as possible. Using built in functions, like the one for github, means I don't need to worry about future URL changes since the ports system handles it.
safihre wrote:Just use the master branch, we only push there in case of a new stable release. Indeed the tags are on develop, without the version set.
The ports system must be able to just wget or curl a file? Not just git tags?
You can set just a URL to download from using MASTER_SITES, but I think the FreeBSD devs prefer using the github integration when possible.
Looks like the best option is to use the specific commit hash so that it pulls from master and for that specific version. Easy one line change to the Makefile and frequently done in the ports system.
safihre wrote:Just use the master branch, we only push there in case of a new stable release. Indeed the tags are on develop, without the version set.
The ports system must be able to just wget or curl a file? Not just git tags?
Any reason the releases can't reference the master branch?
That way anyone can just pull the tagname and get the expected source.