Sample deletion as before

Want something added? Ask for it here.
Post Reply
ErikBrown
Release Testers
Release Testers
Posts: 130
Joined: December 20th, 2009, 1:25 am
Location: Home

Sample deletion as before

Post by ErikBrown » June 14th, 2019, 4:25 pm

Hi,

The deletion of samples has been changed in version 2.3.9 as per the change log. But now I get lots of sample files. Would it be possible to make it optional to delete the files again as before so that the user can decide to automatically remove all the files with sample in the name or not?

Thanks,
Erik

pxr5
Newbie
Newbie
Posts: 20
Joined: July 22nd, 2008, 5:10 am

Re: Sample deletion as before

Post by pxr5 » June 15th, 2019, 4:37 am

I've started to get samples coming back too. The above would be useful.

User avatar
safihre
Administrator
Administrator
Posts: 3311
Joined: April 30th, 2015, 7:35 am
Location: Switzerland
Contact:

Re: Sample deletion as before

Post by safihre » June 15th, 2019, 6:29 am

Could you send me example NZBs where you are getting too many samples?
It should only not delete them if all files contain the word "sample" or "proof" or in case there's only 1 file.

ErikBrown
Release Testers
Release Testers
Posts: 130
Joined: December 20th, 2009, 1:25 am
Location: Home

Re: Sample deletion as before

Post by ErikBrown » June 15th, 2019, 10:53 am

Hi Safihre,

I have emailed you at your personal email address at sabnzbd dot org some NZBs that cause sample files not to be deleted.

Regards,
Erik

pxr5
Newbie
Newbie
Posts: 20
Joined: July 22nd, 2008, 5:10 am

Re: Sample deletion as before

Post by pxr5 » June 16th, 2019, 10:40 am

Hi safihre,

I've emailed you one as well.

User avatar
safihre
Administrator
Administrator
Posts: 3311
Joined: April 30th, 2015, 7:35 am
Location: Switzerland
Contact:

Re: Sample deletion as before

Post by safihre » June 17th, 2019, 12:55 am

Found the issue with your NZB's.
Bad testing on my part, didn't test the case with just 1 sample file.

ErikBrown
Release Testers
Release Testers
Posts: 130
Joined: December 20th, 2009, 1:25 am
Location: Home

Re: Sample deletion as before

Post by ErikBrown » June 17th, 2019, 3:51 am

Thanks for fixing it!

pxr5
Newbie
Newbie
Posts: 20
Joined: July 22nd, 2008, 5:10 am

Re: Sample deletion as before

Post by pxr5 » June 17th, 2019, 6:40 am

Thanks from me too :-)

osen
Newbie
Newbie
Posts: 4
Joined: November 4th, 2010, 6:01 pm

Re: Sample deletion as before

Post by osen » August 17th, 2019, 1:02 pm

Sorry for bumping this thread, but what was the fix for this? I'm on latest release (2.3.9) and I'm experiencing this problem. Do I have to build from source to get the fix?

User avatar
jcfp
Release Testers
Release Testers
Posts: 896
Joined: February 7th, 2008, 12:45 pm

Re: Sample deletion as before

Post by jcfp » August 18th, 2019, 2:34 am

osen wrote:
August 17th, 2019, 1:02 pm
Sorry for bumping this thread, but what was the fix for this? I'm on latest release (2.3.9) and I'm experiencing this problem. Do I have to build from source to get the fix?
https://github.com/sabnzbd/sabnzbd/comm ... 8083b36548

There's no release yet that includes that commit though.

osen
Newbie
Newbie
Posts: 4
Joined: November 4th, 2010, 6:01 pm

Re: Sample deletion as before

Post by osen » August 18th, 2019, 9:38 am

jcfp wrote:
August 18th, 2019, 2:34 am
osen wrote:
August 17th, 2019, 1:02 pm
Sorry for bumping this thread, but what was the fix for this? I'm on latest release (2.3.9) and I'm experiencing this problem. Do I have to build from source to get the fix?
https://github.com/sabnzbd/sabnzbd/comm ... 8083b36548

There's no release yet that includes that commit though.
I see. Successfully installed from source and sample deletion does indeed seem to be working again. I read the first post too fast, didn't notice this "bug" was introduced in 2.3.9 so I guess simply downgrading to 2.3.8 for the time being would be a lot more convenient.

Thank you very much.

Post Reply