Possible bug? Script editing changes speed and pauses all downloads

Report & discuss bugs found in SABnzbd
Forum rules
Help us help you:
  • Are you using the latest stable version of SABnzbd? Downloads page.
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
Post Reply
MajorHavoc
Newbie
Newbie
Posts: 26
Joined: July 10th, 2008, 10:46 pm

Possible bug? Script editing changes speed and pauses all downloads

Post by MajorHavoc »

I have the following schedule items:
Daily: 06:00: Speedlimit 60
Monday through Friday: 12:00: pause (as 5 schedule items, one for each day)
Daily: 19:00: Resume
Daily:19:01: Speedlimit 75
Daily:23:30: Speedlimit 100

The schedules work fine when left alone. However, if I try and edit the schedule in the morning, say 11 AM  (for example, I removed a Daily: 23:00: Speedlimit 100 and replaced it with the 23:30 one, or add a new Speedlimit change, or remove one), all downloads immediately go to PAUSE, and the the speed limit is set to 60.

It almost seems as if the program parses the schedule and sets the conditions as they would be for the time at which the edit takes place. That is cool, and explains the speedlimit 60, but not the pause.

Is this a bug, or as designed?

Thanks
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Possible bug? Script editing changes speed and pauses all downloads

Post by shypike »

Yes, it does evaluation of the speed at restart (i.e. after chaning the schedule).
I would have to check the exact situation regarding the pauses.
MajorHavoc
Newbie
Newbie
Posts: 26
Joined: July 10th, 2008, 10:46 pm

Re: Possible bug? Script editing changes speed and pauses all downloads

Post by MajorHavoc »

Thanks. The speed thing makes sense. It just does not come out of PAUSE. Now this could be an eval thing as well, but I posted my schedule as it, so it should know it is running. UNLESS, you start the eval of the schedule at a time other than midnight?
Cheers
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Possible bug? Script editing changes speed and pauses all downloads

Post by shypike »

So far I cannot reproduce your problem.

When the current state is Paused, the schedule evaluation will never set the
state to Resume. This prevents spontaneous resumption during schedule editing.
When the current state is Resume, the schedule evaluation can cause a Pause.

I'll file it as a bug (#81), but since I cannot reproduce it so far, it will take some time.
Last edited by shypike on August 11th, 2008, 4:32 pm, edited 1 time in total.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Possible bug? Script editing changes speed and pauses all downloads

Post by shypike »

I had some problem deriving the specification from the code.
The current behavior is not easy to explain, therefore what will be done is this.
(Taken from the text of ticket #81).
Schedule changes, cause a re-evaluation of the schedule. Now spontaneous resume of a paused download is prevented. This is a safety measure to prevent spontaneous resumption during schedule edits. However this feature is difficult to explain and gives a feeling of unpredictability.

Change the code so that the evaluated pause/resume state is used. (Note: the feature that a command-line "-p" overrules the schedule, should be kept).
It could be that some side-effect or error causes your problem.
With the above change, your problem should go away anyway.
MajorHavoc
Newbie
Newbie
Posts: 26
Joined: July 10th, 2008, 10:46 pm

Re: Possible bug? Script editing changes speed and pauses all downloads

Post by MajorHavoc »

That will work. Thanks.
Post Reply