pre-check on contents of post for unwanted content

[andymac]

Great! Like I said, I haven't gotten a chance to pull the clone and set it up to test yet. Just slammed the existing code (with a small abort modification) into my existing SAB, but I love the idea! So far, my issue is that for each of the files, it says it cannot be inspected. So I ended up with the same crap. Guess I'll have to wait till I'm home and can download your clone and set it up.

EDIT: I went ahead and ssh'd to my box to give it a shot (cloning). Initial results are good! Not having the same issue with not inspecting the files, so I must have typed something wrong on my own try. I'll run it for a bit and report back later. Definitely keep us updated on when this gets merged in to the main! It'd be very useful!

EDIT2: And the final test ... two known files that have issues finished their run and failed, as they should. Thanks! This update is great .

[sander]

FYI:

The git version of SABnzbd 0.7.x has the Unwanted Exension feature built-in, including its configuration via the SABnzbd GUI:



HTH

[lujon]

I pulled from git, but I don't see this option which part of the web UI is it located?

TIA

[sander]

I pulled from git, but I don't see this option which part of the web UI is it located?

TIA

In Config -> Switches.

If it is not there: did you select branch 0.7.x?

So:

Code: Select all

git clone https://github.com/sabnzbd/sabnzbd.git sabnzbd
cd sabnzbd/
git checkout 0.7.x

Then:

Code: Select all

$ git branch
* 0.7.x
  master

and

Code: Select all

grep -ir unwanted *

should give output

[lujon]

That did the trick. Thanks so much!

[iceberg]

Does anybody know how to configure this on a Synology NAS? I have the SynoCommunity package installed running 0.7.17 and I couldn't get the package to run once I incorporated the edits I found on Github.

[andymac]

Thanks for the git commands, Sander, I always have to go look up the switch ones.

Either way, yes, this is working for me in 0.7.x as well. Hopefully someone will ping this board again if / when this change hits master (I generally prefer to sit on master).

[sander]

Does anybody know how to configure this on a Synology NAS? I have the SynoCommunity package installed running 0.7.17 and I couldn't get the package to run once I incorporated the edits I found on Github.

*If* you can run the SABnzbd source package on Synology, I suppose you can download https://github.com/sabnzbd/sabnzbd/archive/0.7.x.zip, unpack it into some normal user directory, and run it with ./SABnzbd.py.

EDIT: Oh, the above is only useful for testing. It is NOT (I repeat: NOT) an installation procedure for Synology. You have to wait for the Synlogy packaging person, which is NOT the same as the SAB creator(s).

[topsy]

Great work guys. Your hard work and ingenuity is much appreciated.
Really looking forward to this hitting main.
It is enterprise like this that has encouraged me to make a contribution, (buttons to do so is a bit subtle).

There are that many fake uploads appearing it is affecting the usefulness of Couch.
I wonder whether it is an individual that uploads the fakes or it is a corporate retaliation against downloads?

Thanks again.

[pentafive]

sander,

1st off thanks for the awesome work on this. I have been using it and it works very well. (still using your original hardcode mod).

I have a few ideas to improve this and wanted to get your input.

1. Ability to restrict the unwanted filename checking to a specific category (say movies only in my case).
2. Remap the download order of a NZB file to get the last partXX.rar file 1st. Most setup.exes are stored at the end of the release. If you move the last rar file up to be downloaded 1st it would trigger this code and abort the download quicker saving even more bandwidth and time. Otherwise (for most releases) it would download 40 rars then abort on the last one.

Thoughts?

Thanks,
Pentafive

[sander]

@pentafive:

You use the harcode mod, meaning the proof-of-concept code snippets I've posted here? Not the git version? AFAIK the git version is more elegant. If you run SABnzbd from source (on Linux) using the git version is just a few commands away.

Anyway:
I understand your needs. Good points.
Ad 1: How do you see to set that up? "Exclude .exe .com .apk for categories Movies, XXX, Music"? Or a matrix-like setting with extension per Category?
Ad 2: My experience is the opposite: always in the first par. However: I can imagine that the posters change post behaviour to circumvent this upcoming SAB feature. Anyway: can you PM me such an NZB?

Furthermore: I want to wait for 0.7.18 with the current Unwanted Extensions implemented, then wait for user experiences, and then proceed. Maybe I will need help from Shypike how to implement your suggestion 2 ... I have no idea how to steer SAB to download the last par first.

[pentafive]

You use the harcode mod, meaning the proof-of-concept code snippets I've posted here? Not the git version? AFAIK the git version is more elegant. If you run SABnzbd from source (on Linux) using the git version is just a few command away.

Yeah it is me being lazy and not swapping out the code. You know, if it works...

Ad 1: How do you see to set that up? "Exclude .exe .com .apk for categories Movies, XXX, Music"? Or a matrix-like setting with extension per Category?

I would say something simple like "Exclude .exe .com .apk for categories Movies, XXX, Music"

Ad 2: My experience is the opposite: always in the first par. However: I can imagine that the posters change post behaviour to circumvent this upcoming SAB feature. Anyway: an you PM me such an NZB?

Sent..

Furthermore: I want to wait for 0.7.18 with the current Unwanted Extensions implemented, then wait for user experiences, and then proceed. Maybe I will need help from Shypike how to implement your suggestion 2 ... I have no idea how to steer SAB to download the last par first.

Understandable, if you want to do any hard code tests before hand I am game. I tried to do #1, but I just don't know enough about sabnzb to know what var to eval.

Thanks!

[sander]

Thanks for the PM. In general terms: one can find the NZB via "2014.LIMITED.720p.BluRay.x264-tGc" on binsearch.

I can confirm the .exe is in the last rar (par42), and not in the first rar. Hmmm. If SAB would check the first and the last rar, would the problem be solved? Or can the 'poster' also put the in exe in any rar, for example rar #22? If so, checking for the unwanted extensions in an early download phase will be difficult.

[pentafive]

If SAB would check the first and the last rar, would the problem be solved? Or can the 'poster' also put the in exe in any rar, for example rar #22? If so, checking for the unwanted extensions in an early download phase will be difficult.

I think that would be perfect. Most offending files are in the 1st or last rar.

[LiltTrublMakr]

Sorry for the noob post, I am very new to all of this and love it so far.

I have noticed a ton of the movies I have tried to retrieve have been getting the AVI file with the codec executable. Having common sense, if it seems like a trap, it most likely is. I always delete all of the files without opening them to hopefully not get a virus/malware.

Anyways, to my post...

How would I go about implementing this in a Win8.1 installation? I tried searching for 'assembler.py' and can not find it. Would I have to go from the python source instead of the windows executable? If so, does anyone know if I can keep all of my settings so I don't have to start over again?

Thanks

(off track) EDIT: Darn it... Added a 't' in my name while registering... Ah well