Duplicate NZB detector: Lowercase vs Uppercase.

Report & discuss bugs found in SABnzbd
Forum rules
Help us help you:
  • Are you using the latest stable version of SABnzbd? Downloads page.
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
Post Reply
Sypher
Release Testers
Release Testers
Posts: 75
Joined: April 10th, 2008, 10:23 am

Duplicate NZB detector: Lowercase vs Uppercase.

Post by Sypher »

This is either a bug or a feature request. I'm using the RSS autodownloader and found one annoying thing:
Yesterday it downloaded the NZB called: "Showname.S03E12.720p.HDTV.x264-RLSGROUP".

Today, it downloaded it again but now in all lower case (showname.s03e12.720p.hdtv.x264-rlsgroup).

This is on Linux where both files can exist right next to each other, so thats why it passed the "duplicate nzb detector".
I however would like to see this tweaked a bit so that it won't happen again, seeing there are lots of possibilities here that can cause duplicate downloads.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Duplicate NZB detector: Lowercase vs Uppercase.

Post by shypike »

So you are asking to the check case-insensitive?
I thought it already did that, but I will check this later.
So indeed it may be a bug or a feature request.
I agree that the check should be case-insensitive.
Sypher
Release Testers
Release Testers
Posts: 75
Joined: April 10th, 2008, 10:23 am

Re: Duplicate NZB detector: Lowercase vs Uppercase.

Post by Sypher »

shypike wrote:So you are asking to the check case-insensitive?
Yeah, if you put it like that... That's what I'm asking :)
The version used was Beta6 by the way.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Duplicate NZB detector: Lowercase vs Uppercase.

Post by shypike »

There are two checks.
One is the title check in RSS, current case-sensitive, but that's trivial to change.
The other one against the backed-up NZB file is a bit tricky, at least for Linux.
(For Windows and OSX it's a non-issue).
I'll see what I can do.

You would probably have been "saved" by the first check.
Sypher
Release Testers
Release Testers
Posts: 75
Joined: April 10th, 2008, 10:23 am

Re: Duplicate NZB detector: Lowercase vs Uppercase.

Post by Sypher »

This bug is apparently still alive and kicking in the 0.5.0 stable build.

CHUCK vs Chuck means a new download with the name.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Duplicate NZB detector: Lowercase vs Uppercase.

Post by shypike »

I don't know how you test, but the title check is case-insensitive.
What changes: the case in the title or your filter?

The NZB filename check is case-insensitive on Windows and OSX, not on Linux.
We won't implement a case-insensitive test on Linux.
Sypher
Release Testers
Release Testers
Posts: 75
Joined: April 10th, 2008, 10:23 am

Re: Duplicate NZB detector: Lowercase vs Uppercase.

Post by Sypher »

shypike wrote:We won't implement a case-insensitive test on Linux.
Mind telling me why? I don't see the point on not-implementing it.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Duplicate NZB detector: Lowercase vs Uppercase.

Post by shypike »

Because Linux happens to have a case-sensitive file system.
Adding the code to work around that is rather counter productive.
Besides, the NZB backup system is intended to prevent true duplicates, not similar files.
Having different casing means that the source is different, and therefor not a true duplicate.

I'd see more use in extending the RSS duplicate check to
examine titles from all feeds instead of just the ones from the examined feed (as it does now).
Sypher
Release Testers
Release Testers
Posts: 75
Joined: April 10th, 2008, 10:23 am

Re: Duplicate NZB detector: Lowercase vs Uppercase.

Post by Sypher »

I know Linux is case-sensitive, but its giving me quite some false-positives.
How about making it an option then? I really do not want the download the same file again if one letter is uppercased and the other one is not.
Or automatically (option?) lowercasing the nzb's.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Duplicate NZB detector: Lowercase vs Uppercase.

Post by shypike »

I'll implement my last suggestion instead.
It's much more useful.
It will solve your issue just as well.

We already have too many crazy options :)
Sypher
Release Testers
Release Testers
Posts: 75
Joined: April 10th, 2008, 10:23 am

Re: Duplicate NZB detector: Lowercase vs Uppercase.

Post by Sypher »

shypike wrote: I'll implement my last suggestion instead.
It's much more useful.
It will solve your issue just as well.
Ok, cool.
shypike wrote: We already have too many crazy options :)
Gives people a choice eh ;)
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: Duplicate NZB detector: Lowercase vs Uppercase.

Post by shypike »

Sypher wrote: Gives people a choice eh ;)
But it does make testing a nightmare.

BTW, I discovered a little error. When you click the download link in the RSS listing
the NZB is downloaded, but the NZB is flagged later as downloaded.
Defeated my duplicate check while testing :)

BTW: in which situations do you have problems with duplicates?
Within one feed or across feeds?
The first one should not be a problem, since current title comparison is already case-insensitive.
Sypher
Release Testers
Release Testers
Posts: 75
Joined: April 10th, 2008, 10:23 am

Re: Duplicate NZB detector: Lowercase vs Uppercase.

Post by Sypher »

I'm only using one feed: TVnzb, with lots and lots of filters :)
Post Reply